[Mellanox] [202012] Fix issue: 4600C is using wrong thermal profile #10258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azpw run Azure.sonic-buildimage |
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azpw run Azure.sonic-buildimage |
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1676747 to
ab6339b
Compare
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
liat-grozovik
approved these changes
Mar 20, 2022
Merged
5 tasks
liat-grozovik
pushed a commit
to sonic-net/sonic-mgmt
that referenced
this pull request
Jun 28, 2022
4600C was using wrong thermal profile and it displays 2 CPU core thermal in show platform temperature output, there should be 4 CPU core thermal. The PR in sonic-buildimage has fixed this: sonic-net/sonic-buildimage#10258 The sonic-mgmt platform thermal test should also be fixed to align with the output change. - What is the motivation for this PR? Fix cpu core number for 4600c in platform info thermal test. - How did you do it? Correcting the thermal cpu core number for 4600c to 4 in tests/common/mellanox_data.py. - How did you verify/test it? Run test case in master and 202012 branch on 4600c by automation, all passed. - Any platform specific information? The change is only for 4600c.
yxieca
pushed a commit
to sonic-net/sonic-mgmt
that referenced
this pull request
Oct 6, 2022
4600C was using wrong thermal profile and it displays 2 CPU core thermal in show platform temperature output, there should be 4 CPU core thermal. The PR in sonic-buildimage has fixed this: sonic-net/sonic-buildimage#10258 The sonic-mgmt platform thermal test should also be fixed to align with the output change. - What is the motivation for this PR? Fix cpu core number for 4600c in platform info thermal test. - How did you do it? Correcting the thermal cpu core number for 4600c to 4 in tests/common/mellanox_data.py. - How did you verify/test it? Run test case in master and 202012 branch on 4600c by automation, all passed. - Any platform specific information? The change is only for 4600c.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
4600C is using wrong thermal profile and it displays 2 CPU core thermal in
show platform temperatureoutput, there should be 4 CPU core thermal.How I did it
Change 4600C to use thermal profile 10.
How to verify it
Manual test
Which release branch to backport (provide reason below if selected)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)