Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DellEMC: Z9332f - Component API Fixes #10187

Merged

Conversation

ArunSaravananBalachandran
Copy link
Contributor

@ArunSaravananBalachandran ArunSaravananBalachandran commented Mar 9, 2022

Why I did it

To update the available and current firmware versions provided by Component APIs

How I did it

Update the platform API methods in component.py

How to verify it

Verified that component data is displayed by show platform firmware status.
Logs: UT_logs.txt

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111

Description for the changelog

DellEMC: Z9332f - Component API Fixes

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@gechiang
Copy link
Collaborator

gechiang commented Mar 9, 2022

Can you also show a sample output of the show output similar to what you captured in UT_logs.txt where it is run against the code that is before your fix is in place so we can see what are the differences and what you are attempting to fix with this PR?
This will make the review much easier.
Thanks!

@ArunSaravananBalachandran
Copy link
Contributor Author

Can you also show a sample output of the show output similar to what you captured in UT_logs.txt where it is run against the code that is before your fix is in place so we can see what are the differences and what you are attempting to fix with this PR? This will make the review much easier. Thanks!

As suggested, have attached the updated logs UT_logs.txt

Copy link
Collaborator

@gechiang gechiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
If @sujinmkang also approve this change we should go ahead help merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants