Skip to content

Commit

Permalink
[PMON] Extend pmon daemon start control to lm-sensors and fancontrol …
Browse files Browse the repository at this point in the history
…for 201911 (#4487)

Extend the PMON daemon start control to lm-sensors and fancontrol.

change template docker-pmon.supervisord.conf.j2 and start.sh.j2 to have lm-sensors and fancontrol start scripts and supervisord config file controlled by pmon_daemon_control.json.

the intention is to avoid wrong daemon status in "supervisorctl status" output. For example, on some platform, if there is no fancontrol config file, and it is not ruled out from supervisord conf file and start.sh, we'll see fancontrol in "STOPPED" status from "supervisorctl status" output, which will violate some check in the platform test(check daemon status as expected)
  • Loading branch information
keboliu authored Apr 29, 2020
1 parent 827aab7 commit e12d2e8
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 1 deletion.
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
{
"skip_ledd": true
"skip_ledd": true,
"skip_fancontrol": true
}

Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ autorestart=false
stdout_logfile=syslog
stderr_logfile=syslog

{% if not skip_sensors %}
[program:lm-sensors]
command=/usr/bin/lm-sensors.sh
priority=3
Expand All @@ -34,7 +35,9 @@ autorestart=false
stdout_logfile=syslog
stderr_logfile=syslog
startsecs=0
{% endif %}

{% if not skip_fancontrol %}
[program:fancontrol]
command=/usr/sbin/fancontrol
priority=4
Expand All @@ -43,6 +46,7 @@ autorestart=unexpected
stdout_logfile=syslog
stderr_logfile=syslog
startsecs=10
{% endif %}

{% if not skip_ledd %}
[program:ledd]
Expand Down
4 changes: 4 additions & 0 deletions dockers/docker-platform-monitor/start.sh.j2
Original file line number Diff line number Diff line change
Expand Up @@ -19,14 +19,17 @@ if [ -e /usr/share/sonic/platform/platform_wait ]; then
fi
fi

{% if not skip_sensors %}
# If this platform has an lm-sensors config file, copy it to it's proper place
# and start lm-sensors
if [ -e /usr/share/sonic/platform/sensors.conf ]; then
mkdir -p /etc/sensors.d
/bin/cp -f /usr/share/sonic/platform/sensors.conf /etc/sensors.d/
supervisorctl start lm-sensors
fi
{% endif %}

{% if not skip_fancontrol %}
# If this platform has a fancontrol config file, copy it to it's proper place
# and start fancontrol
if [ -e /usr/share/sonic/platform/fancontrol ]; then
Expand All @@ -36,6 +39,7 @@ if [ -e /usr/share/sonic/platform/fancontrol ]; then
/bin/cp -f /usr/share/sonic/platform/fancontrol /etc/
supervisorctl start fancontrol
fi
{% endif %}


# If the sonic-platform package is not installed, try to install it
Expand Down

0 comments on commit e12d2e8

Please sign in to comment.