Added Support for Dell EMC S5212f in SONiC

sonic-net · Sep 8, 2021 · 0c4f15f · 0c4f15f
1 parent 0fd1ed2
commit 0c4f15f
Showing 1 changed file with 3 additions and 9 deletions.
diff --git a/platform/broadcom/sonic-platform-modules-dell/s5212f/sonic_platform/sfp.py b/platform/broadcom/sonic-platform-modules-dell/s5212f/sonic_platform/sfp.py
@@ -12,11 +12,7 @@
     import os
     import time
     import struct
-    import sys
-    import getopt
-    import select
     import mmap
-    from sonic_platform_base.chassis_base import ChassisBase
     from sonic_platform_base.sfp_base import SfpBase
     from sonic_platform_base.sonic_sfp.sff8436 import sff8436InterfaceId
     from sonic_platform_base.sonic_sfp.sff8436 import sff8436Dom
@@ -710,7 +706,6 @@ def get_temperature(self):
         """
         Retrieves the temperature of this SFP
         """
-        temperature = 'N/A'
         try :
             temperature_data = self._get_eeprom_data('Temperature')
             temperature = temperature_data['data']['Temperature']['value']
@@ -722,7 +717,6 @@ def get_voltage(self):
         """
         Retrieves the supply voltage of this SFP
         """
-        voltage = 'N/A'
         try:
             voltage_data = self._get_eeprom_data('Voltage')
             voltage = voltage_data['data']['Vcc']['value']
@@ -817,15 +811,15 @@ def reset(self):
                 reg_value = reg_value & ~mask
 
                 # Convert our register value back to a hex string and write back
-                status = self.pci_set_value(self.BASE_RES_PATH, reg_value, port_offset)
+                self.pci_set_value(self.BASE_RES_PATH, reg_value, port_offset)
 
                 # Sleep 1 second to allow it to settle
                 time.sleep(1)
 
                 reg_value = reg_value | mask
 
                 # Convert our register value back to a hex string and write back
-                status = self.pci_set_value(self.BASE_RES_PATH, reg_value, port_offset)
+                self.pci_set_value(self.BASE_RES_PATH, reg_value, port_offset)
         except  ValueError:
             return  False
         return True
@@ -852,7 +846,7 @@ def set_lpmode(self, lpmode):
                     reg_value = reg_value & ~mask
 
                 # Convert our register value back to a hex string and write back
-                status = self.pci_set_value(self.BASE_RES_PATH, reg_value, port_offset)
+                self.pci_set_value(self.BASE_RES_PATH, reg_value, port_offset)
         except  ValueError:
             return  False
         return True