-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Prepare HLD documents for CLI sessions feature Update ssh_config.md with auto-logout and max-syslogins parameters. Create serial-console-HLD.md
- Loading branch information
1 parent
40a3a13
commit 2c4c01d
Showing
4 changed files
with
246 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,214 @@ | ||
| # Serial-console global config HLD | ||
| ## <a name='TableofContent'></a>Table of Content | ||
| - [Serial-console config HLD](#serial-console-global-config-hld) | ||
| - [Table of Content](#table-of-content) | ||
| - [Revision](#revision) | ||
| - [1. Introduction](#11-introduction) | ||
| - [1.1. Scope](#11-scope) | ||
| - [1.2. Definitions/Abbreviations](#12-definitionsabbreviations) | ||
| - [1.3. Overview](#13-overview) | ||
| - [1.4. Requirements](#14-requirements) | ||
| - [2. Architecture Design](#2-architecture-design) | ||
| - [2.1. Configuration modules](#21-configuration-modules) | ||
| - [3. High-Level Design](#3-high-level-design) | ||
| - [Flow diagram](#flow-diagram) | ||
| - [3.1 Flow description](#31-flow-description) | ||
| - [3.2 serial-console configurations](#32-serial-console-configurations) | ||
| - [4. Init flow](#4-init-flow) | ||
| - [4.1. Feature Default](#41-feature-default) | ||
| - [5. SAI api](#19-sai-api) | ||
| - [6. Configuration and management](#6-configuration-and-management) | ||
| - [6.1. SERIAL_CONNECTION configDB table](#61-serial-connection-configdb-table) | ||
| - [6.2. ConfigDB schemas](#62-configdb-schemas) | ||
| - [6.3. CLI/YANG model Enhancements](#63-cliyang-model-enhancements) | ||
| - [6.4. Config DB Enhancements](#64-config-db-enhancements) | ||
| - [6.5. Manifest (if the feature is an Application Extension)](#65-manifest-if-the-feature-is-an-application-extension) | ||
| - [7. Warmboot and Fastboot Design Impact](#7-warmboot-and-fastboot-design-impact) | ||
| - [8. Restrictions/Limitations](#8-restrictionslimitations) | ||
| - [9. Testing Requirements/Design](#9-testing-requirementsdesign) | ||
| - [9.1. Unit Test cases](#91-unit-test-cases) | ||
| - [9.2. System Test cases](#92-system-test-cases) | ||
| - [10. Open/Action items - if any](#10-openaction-items---if-any) | ||
| ### <a name='Revision'></a>Revision | ||
|
|
||
| | Rev | Date | Author | Change Description | | ||
| | :---: | :------: | :--------: | ------------------ | | ||
| | 0.1 | 16/06/23 | Ivan Davydenko | Initial version | | ||
|
|
||
| ## 1 <a name='Introduction'></a>Introduction | ||
|
|
||
| ### 1.1. <a name='Scope'></a>Scope | ||
|
|
||
| This hld doc for serial cli global configurations describes the requirements, architecture and general flow details of serial connection config in SONIC OS based switches. | ||
|
|
||
| ### 1.2. <a name='DefinitionsAbbreviations'></a>Definitions/Abbreviations | ||
|
|
||
| serial - secure shell | ||
| TCP - Transmission Control protocol | ||
|
|
||
| ### 1.3. <a name='Overview'></a>Overview | ||
|
|
||
| We want to allow configuring serial console global settings. This will feature will include two configurations on first phase. | ||
|
|
||
| ### 1.4. <a name='Requirements'></a>Requirements | ||
|
|
||
| This feature requires a dedicated table in the configuration DB, enhancements of hostcfg demon and separate service that updates configutaion files. In order to update the serial-console configurations, we need to have write access in /etc/profile.d/, /proc/sys/kernel/sysrq and /etc/sysctl.d/95-sysrq-sysctl.conf. | ||
|
|
||
| ## 2. <a name='ArchitectureDesign'></a>Architecture Design | ||
| ### 2.1. <a name='ConfigModules'></a>Configuration modules | ||
|  | ||
|
|
||
| We want to enhance configDB to include table for serial-console global configurations. In addition, serial_console.service will be added to modify configuration files. | ||
|
|
||
| ## 3. <a name='High-LevelDesign'></a>High-Level Design | ||
|
|
||
| We want to enable serial-console configuration in SONIC. In order to do so will touch few areas in the system: | ||
| 1. configDB - to include a dedicated table for configurations | ||
| 2. hostcfg demon - to trigger dedicated service on config apply. | ||
| 3. OS config files - specific for this stage we are only /etc/profile.d/serial_tmout.sh and /etc/sysctl.d/95-sysctl.d/95-sysrq-sysctl.conf and /proc/sys/kernel/sysrq are going to be modifed by the service-script. | ||
|
|
||
| ##### Flow diagram | ||
|  | ||
| ### 3.1 <a name='Flow description'></a>Flow description | ||
| When the feature is enabled, by modifying the DB manually, user will set serial-console configurations by modifing CONFIG_DB in SERIAL_CONSOLE table. | ||
|
|
||
| The hostcfgd daemon will be extended to listen to confogurations from SERIAL_CONSOLE table and restarts the serial_console.service. Serial console script will read SERIAL_CONSOLE table and update config files accordingly. | ||
|
|
||
|
|
||
| ### 3.2 <a name='serial-console configurations'></a>serial-console configurations | ||
|
|
||
| We want to enable configuring the following attributes: | ||
| | Policy | Action | Param values | Default | | ||
| |--------------------|-----------------------------------------------------------------------|---------------------|--------------| | ||
| | auto logout | Inactivity timeout for serial-console session | 0-35000 (min) | 15 | | ||
| | sysrq capabilities | Enabling or disabling SysRq functionality for serial-consoles | enabled/disabled | disabled | | ||
|
|
||
|
|
||
| ## 4. <a name='Init flow'></a>Init flow | ||
|
|
||
| During init flow we will set default configurations as mentioned in the table abowe. Default values will be added to init_cfg.json.j2 . | ||
| ### 4.1. <a name='FeatureDefault'></a>Feature Default | ||
|
|
||
| Description of default values in init_cfg.json regarding serial-console config: | ||
| ``` | ||
| auto logout: 15 //minutes | ||
| sysrq capabilities: disabled | ||
| ``` | ||
| ## 5. <a name='SAI api'></a>SAI api | ||
| NA | ||
| ## 6. <a name='Configurationandmanagement'></a>Configuration and management | ||
|
|
||
| ### 6.1. <a name='SERIAL_CONSOLEconfigDBtable'></a>SERIAL_CONSOLE configDB table | ||
|
|
||
| ``` | ||
| SERIAL_CONSOLE:{ | ||
| "auto_logout": {{min}} | ||
| "sysrq-capabilities": {{enabled|disabled}} | ||
| } | ||
| ``` | ||
| ### 6.2. ConfigDB schemas | ||
| ``` | ||
| ; Defines schema for SERIAL_CONSOLE configuration attributes in SERIAL_CONSOLE table: | ||
| auto_logout = 5*DIGIT ; autologout timer - max is 35000 minutes | ||
| max_syslogins = "enabled/disabled" ; enabling or disabling sysrq capabilities in linux, default is disabled. | ||
| ``` | ||
|
|
||
| ### 6.3. <a name='CLIYANGmodelEnhancements'></a>CLI/YANG model Enhancements | ||
| ```yang | ||
| //filename: sonic-serial-console.yang | ||
| module sonic-serial-console { | ||
| yang-version 1.1; | ||
| namespace "http://github.com/Azure/sonic-serial-console"; | ||
| prefix cli-sessions; | ||
| description "SERIAL_CONSOLE YANG Module for SONiC-based OS"; | ||
| revision 2023-06-07 { | ||
| description "First Revision"; | ||
| } | ||
| container sonic-serial-console { | ||
| container SERIAL_CONSOLE { | ||
| description "SERIAL_CONSOLE part of config_db.json"; | ||
| key "name"; | ||
| leaf auto_logout { | ||
| description "serial-console auto-logout timer value in minutes"; | ||
| type int32 { | ||
| range "0..15000"; | ||
| } | ||
| default 15; | ||
| } | ||
| leaf sysrq_capabilities { | ||
| description "managing SysRq capabilities"; | ||
| type enumeration { | ||
| enum disabled; | ||
| enum enabled; | ||
| } | ||
| default disabled; | ||
| } | ||
| } | ||
| /* end of container SERIAL_CONSOLE */ | ||
| } | ||
| /* end of top level container */ | ||
| } | ||
| /* end of module sonic-serial-console */ | ||
| ``` | ||
| ### 6.4. <a name='ConfigDBEnhancements'></a>Config DB Enhancements | ||
|
|
||
| The ConfigDB will be extended with next objects: | ||
|
|
||
| ```json | ||
| { | ||
| "SERIAL_CONSOLE": { | ||
| "auto_logout": "15", | ||
| "sysrq_capabilities": "disabled", | ||
| } | ||
| } | ||
| ``` | ||
|
|
||
| ### 6.5. <a name='ManifestifthefeatureisanApplicationExtension'></a>Manifest (if the feature is an Application Extension) | ||
|
|
||
|
|
||
| NA | ||
|
|
||
| ## 7. <a name='WarmbootandFastbootDesignImpact'></a>Warmboot and Fastboot Design Impact | ||
| NA | ||
|
|
||
| ## 8. <a name='RestrictionsLimitations'></a>Restrictions/Limitations | ||
|
|
||
| ## 9. <a name='TestingRequirementsDesign'></a>Testing Requirements/Design | ||
| Explain what kind of unit testing, system testing, regression testing, warmboot/fastboot testing, etc., | ||
| Ensure that the existing warmboot/fastboot requirements are met. For example, if the current warmboot feature expects maximum of 1 second or zero second data disruption, the same should be met even after the new feature/enhancement is implemented. Explain the same here. | ||
| Example sub-sections for unit test cases and system test cases are given below. | ||
|
|
||
| ### 9.1. <a name='UnitTestcases'></a>Unit Test cases | ||
| Configuration | ||
| 1. Configure auto-logout for serial-console. | ||
| 1.1. Configure and apply non-default auto-logout value (1-2 min.) | ||
| 1.2. Connect and login via serial-console. Validate auto-logout happend in configured time (1-2 min.) | ||
| 2. Init flow for auto-logout. | ||
| 2.1. Don`t save previous auto-logout configuration and reboot the switch. | ||
| 2.2. After boot connect and login via serial-console. Validate that auto-logout didn`t happend in previously configured time (1-2 min.) | ||
| 3. Configure sysrq parameter. | ||
| 3.1. Configure and apply non-default sysrq-capabilities parameter (enabled) | ||
| 3.2. Check sysrq parameter value in linux proc filesystem being changed to new applied value of "1: | ||
| 4. Init flow for sysrq parameter. | ||
| 4.1. Don`t save previous sysrq configuration and reboot the switch. | ||
| 4.2. Check sysrq parameter value in linux proc filesystem being equal to default value of "0". | ||
|
|
||
|
|
||
| ### 9.2. <a name='SystemTestcases'></a>System Test cases | ||
|
|
||
| ## 10. <a name='OpenActionitems-ifany'></a>Open/Action items - if any | ||
|
|
||
|
|
||
| NOTE: All the sections and sub-sections given above are mandatory in the design document. Users can add additional sections/sub-sections if required. |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters