-
-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix breadcrumb rendering #619
Conversation
ce45d7d
to
b921847
Compare
Thanks |
I just merged this, but didn't you want to target 3.x instead ? @core23 |
No, it's a bug on the next major branch. |
Since the 3.0 is still the alpha, the "next major branch" is the 3.x one, no ? |
Oh damn, you're right. We're still on the 2.x stable branch. Must have mixed this with the other projects where the stable one is 3.x. |
A small drawback of the renaming of the branch, it's less easy to know the stable one. |
Equalize all Sonata versions could be useful, going mono repo could help too. Other other might need to rename again branches. Maybe a hint in the readme about the main branch. 🤷🏻♂️ |
Subject
The
execute
method was missing, so the breadcrumb was rendered as an empty block.This is basically a soft-port of https://github.com/sonata-project/SonataBlockBundle/blob/4.x/src/Block/Service/MenuBlockService.php.
I am targeting this branch, because this is a patch for the next stable release.
Changelog