Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix breadcrumb rendering #619

Merged
merged 2 commits into from
Nov 1, 2021
Merged

Conversation

core23
Copy link
Member

@core23 core23 commented Oct 31, 2021

Subject

The execute method was missing, so the breadcrumb was rendered as an empty block.

This is basically a soft-port of https://github.com/sonata-project/SonataBlockBundle/blob/4.x/src/Block/Service/MenuBlockService.php.

I am targeting this branch, because this is a patch for the next stable release.

Changelog

### Changed
- Mark `BaseBreadcrumbMenuBlockService ::getRootMenu` as final

### Fixed
- Fixed breadcrumb rendering

@core23 core23 added the patch label Oct 31, 2021
@core23 core23 requested a review from a team October 31, 2021 20:38
@core23 core23 force-pushed the fix-menu branch 3 times, most recently from ce45d7d to b921847 Compare October 31, 2021 20:56
@core23 core23 requested review from phansys and a team October 31, 2021 20:56
phansys
phansys previously approved these changes Oct 31, 2021
@phansys phansys requested a review from a team October 31, 2021 23:09
@VincentLanglet VincentLanglet merged commit b87a24e into sonata-project:4.x Nov 1, 2021
@VincentLanglet
Copy link
Member

Thanks

@VincentLanglet
Copy link
Member

I just merged this, but didn't you want to target 3.x instead ? @core23

@core23
Copy link
Member Author

core23 commented Nov 1, 2021

I just merged this, but didn't you want to target 3.x instead ? @core23

No, it's a bug on the next major branch.

@core23 core23 deleted the fix-menu branch November 1, 2021 14:24
@VincentLanglet
Copy link
Member

Since the 3.0 is still the alpha, the "next major branch" is the 3.x one, no ?
https://github.com/sonata-project/SonataSeoBundle/releases

@core23
Copy link
Member Author

core23 commented Nov 1, 2021

Since the 3.0 is still the alpha, the "next major branch" is the 3.x one, no ? https://github.com/sonata-project/SonataSeoBundle/releases

Oh damn, you're right.

We're still on the 2.x stable branch. Must have mixed this with the other projects where the stable one is 3.x.

@core23 core23 restored the fix-menu branch November 1, 2021 14:41
@core23 core23 mentioned this pull request Nov 1, 2021
@VincentLanglet
Copy link
Member

Since the 3.0 is still the alpha, the "next major branch" is the 3.x one, no ? https://github.com/sonata-project/SonataSeoBundle/releases

Oh damn, you're right.

We're still on the 2.x stable branch. Must have mixed this with the other projects where the stable one is 3.x.

A small drawback of the renaming of the branch, it's less easy to know the stable one.
I dunno, if we can do something about it to help us.

@core23 core23 deleted the fix-menu branch November 1, 2021 14:47
@jordisala1991
Copy link
Member

Since the 3.0 is still the alpha, the "next major branch" is the 3.x one, no ? https://github.com/sonata-project/SonataSeoBundle/releases

Oh damn, you're right.

We're still on the 2.x stable branch. Must have mixed this with the other projects where the stable one is 3.x.

A small drawback of the renaming of the branch, it's less easy to know the stable one.

I dunno, if we can do something about it to help us.

Equalize all Sonata versions could be useful, going mono repo could help too. Other other might need to rename again branches. Maybe a hint in the readme about the main branch. 🤷🏻‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants