Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update filter creation to correctly handle nested dict filters #180

Merged
merged 1 commit into from
Aug 14, 2017

Conversation

jsh2134
Copy link
Contributor

@jsh2134 jsh2134 commented Aug 9, 2017

previously sending this filter

>>> filters = ~ Filter(ac_score=None, original_ac_score=None)
>>> print filters.filters
 [{'not': {'and': [('original_ac_score', None), ('ac_score', None)]}}]

would end up sending the following to the API:

["not","and"]

@jsh2134 jsh2134 requested a review from davecap August 9, 2017 21:03
@davecap
Copy link
Contributor

davecap commented Aug 9, 2017

Nice catch

@davecap davecap merged commit c11791c into master Aug 14, 2017
@davecap davecap deleted the f-fix-filter-creation branch August 14, 2017 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants