feat(launch): init support of launching applications #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tai271828
commented
Jun 5, 2021
|
The core part of this feature is currently referred to the implementation of |
yungyuc
requested changes
Jun 6, 2021
|
The updated PR is ready to review again. Thanks, team! |
yungyuc
approved these changes
Jun 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the sciwork online sprint today, this is the feature we have implemented for issue: #26 .
Steps to Verify the Pull Request
source scripts/initdevenv use flavor-issue-26devenv launch solvconExpected Result
flavor/flavor-issue-26/application-solvconis createdAdditioinaly Information
This pull request only closes #26 but not fully completes #23 for the follow incomplete tasks and imperfect features:
flavor/usr/,flavor/usr/bin, andflavor/src.I will create follow-up pull requests to complete above tasks later on to prevent a single huge pull request for code review. Inputs are welcome.