-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add autocomplete tags to address form fields on checkout #1542
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although we plan to remove frontend html in a future version of solidus, I think this is good for now. It's a good start for new devs and can (and most likely will) be overridden by more experiences devs anyway.
So, from me 👍
As a bonus, as we're already here we could also add Thanks for your contribution 🍭 |
There's actually that beast here - jQuery.validate that takes care of javascript validations. Not sure if it will play well with the html validations as it's a rather old version. As the address form is the only one to use this plugin, as far as I know, (payment form uses a different plugin), if you consider it appropriate, I can remove I think even for experienced developers - having a reference to what exactly the correct auto-complete attributes are, without having to search for, is great to have. |
👍 for removing |
I'm pro swapping to html5 validations as well, though I know very little about them. |
This looks good to me 👍 I've created a separate issue #1548 to discuss removing jquery.validate in favour of plain HTML validations. One thing that still doesn't autofill correctly is the state/province. Presumably because the dropdown is filled in via javascript. It would be great if that worked (but it may not be possible). |
Thanks @jhawthorn |
* on frontend checkout After this change, Chrome autocompletes all fields per address* * State must be available in the select box to autocomplete Specification available at: * https://html.spec.whatwg.org/multipage/forms.html#attr-fe-autocomplete-given-name Well explained at: * https://cloudfour.com/thinks/autofill-what-web-devs-should-know-but-dont/
After this change, Chrome autocompletes all fields per address*
Specification available at:
Well explained at: