Add shared example for calculator.description

core/spec/models/spree/calculator/default_tax_spec.rb

@@ -1,4 +1,5 @@
 require 'spec_helper'
+require 'shared_examples/calculator_shared_examples'
 
 describe Spree::Calculator::DefaultTax, type: :model do
   let(:address) { create(:address) }
@@ -9,10 +10,7 @@
   let(:included_in_price) { false }
   subject(:calculator) { Spree::Calculator::DefaultTax.new(calculable: rate ) }
 
-  describe ".description" do
-    subject { described_class.description }
-    it { is_expected.to eq("Default Tax") }
-  end
+  it_behaves_like 'a calculator with a description'
 
   context "#compute" do
     context "when given an order" do

core/spec/models/spree/calculator/flat_percent_item_total_spec.rb

@@ -1,13 +1,11 @@
 require 'spec_helper'
+require 'shared_examples/calculator_shared_examples'
 
 describe Spree::Calculator::FlatPercentItemTotal, type: :model do
   let(:calculator) { Spree::Calculator::FlatPercentItemTotal.new }
   let(:line_item) { mock_model Spree::LineItem }
 
-  describe ".description" do
-    subject { described_class.description }
-    it { is_expected.to eq("Flat Percent") }
-  end
+  it_behaves_like 'a calculator with a description'
 
   before { allow(calculator).to receive_messages preferred_flat_percent: 10 }
 

core/spec/models/spree/calculator/flat_rate_spec.rb

@@ -1,12 +1,10 @@
 require 'spec_helper'
+require 'shared_examples/calculator_shared_examples'
 
 describe Spree::Calculator::FlatRate, type: :model do
   let(:calculator) { Spree::Calculator::FlatRate.new }
 
-  describe ".description" do
-    subject { described_class.description }
-    it { is_expected.to eq("Flat Rate") }
-  end
+  it_behaves_like 'a calculator with a description'
 
   let(:order) do
     mock_model(

core/spec/models/spree/calculator/flexi_rate_spec.rb

@@ -1,12 +1,10 @@
 require 'spec_helper'
+require 'shared_examples/calculator_shared_examples'
 
 describe Spree::Calculator::FlexiRate, type: :model do
   let(:calculator) { Spree::Calculator::FlexiRate.new }
 
-  describe ".description" do
-    subject { described_class.description }
-    it { is_expected.to eq("Flexible Rate") }
-  end
+  it_behaves_like 'a calculator with a description'
 
   let(:order) do
     mock_model(

core/spec/models/spree/calculator/free_shipping_spec.rb

@@ -1,8 +1,6 @@
 require 'spec_helper'
+require 'shared_examples/calculator_shared_examples'
 
 describe Spree::Calculator::FreeShipping, type: :model do
-  describe ".description" do
-    subject { described_class.description }
-    it { is_expected.to eq("Free Shipping") }
-  end
+  it_behaves_like 'a calculator with a description'
 end

core/spec/models/spree/calculator/percent_on_line_item_spec.rb

@@ -1,4 +1,5 @@
 require 'spec_helper'
+require 'shared_examples/calculator_shared_examples'
 
 module Spree
   class Calculator
@@ -13,10 +14,7 @@ class Calculator
         end
       end
 
-      describe ".description" do
-        subject { described_class.description }
-        it { is_expected.to eq("Percent Per Item") }
-      end
+      it_behaves_like 'a calculator with a description'
     end
   end
 end

core/spec/models/spree/calculator/percent_per_item_spec.rb

@@ -1,12 +1,10 @@
 require 'spec_helper'
+require 'shared_examples/calculator_shared_examples'
 
 module Spree
   class Calculator
     describe PercentPerItem, type: :model do
-      describe ".description" do
-        subject { described_class.description }
-        it { is_expected.to eq("Percent Per Item") }
-      end
+      it_behaves_like 'a calculator with a description'
     end
   end
 end

core/spec/models/spree/calculator/price_sack_spec.rb

@@ -1,4 +1,5 @@
 require 'spec_helper'
+require 'shared_examples/calculator_shared_examples'
 
 describe Spree::Calculator::PriceSack, type: :model do
   let(:calculator) do
@@ -9,10 +10,7 @@
     calculator
   end
 
-  describe ".description" do
-    subject { described_class.description }
-    it { is_expected.to eq("Price Sack") }
-  end
+  it_behaves_like 'a calculator with a description'
 
   let(:order) { stub_model(Spree::Order) }
   let(:shipment) { stub_model(Spree::Shipment, amount: 10) }

core/spec/models/spree/calculator/refunds/default_refund_amount_spec.rb

@@ -1,4 +1,5 @@
 require 'spec_helper'
+require 'shared_examples/calculator_shared_examples'
 
 describe Spree::Calculator::Returns::DefaultRefundAmount, type: :model do
   let(:line_item_quantity) { 2 }
@@ -9,10 +10,7 @@
   let(:calculator) { Spree::Calculator::Returns::DefaultRefundAmount.new }
   let(:order) { line_item.order }
 
-  describe ".description" do
-    subject { described_class.description }
-    it { is_expected.to eq("Default Refund Amount") }
-  end
+  it_behaves_like 'a calculator with a description'
 
   subject { calculator.compute(return_item) }
 

core/spec/models/spree/calculator/shipping/flat_percent_item_total_spec.rb

@@ -1,15 +1,13 @@
 require 'spec_helper'
+require 'shared_examples/calculator_shared_examples'
 
 module Spree
   module Calculator::Shipping
     describe FlatPercentItemTotal, type: :model do
       let(:variant1) { build(:variant, price: 10.11) }
       let(:variant2) { build(:variant, price: 20.2222) }
 
-      describe ".description" do
-        subject { described_class.description }
-        it { is_expected.to eq("Flat Percent") }
-      end
+      it_behaves_like 'a calculator with a description'
 
       let(:line_item1) { build(:line_item, variant: variant1) }
       let(:line_item2) { build(:line_item, variant: variant2) }

core/spec/models/spree/calculator/shipping/flat_rate_spec.rb

@@ -1,14 +1,12 @@
 require 'spec_helper'
+require 'shared_examples/calculator_shared_examples'
 
 module Spree
   module Calculator::Shipping
     describe FlatRate, type: :model do
       subject { Calculator::Shipping::FlatRate.new(preferred_amount: 4.00) }
 
-      describe ".description" do
-        subject { described_class.description }
-        it { is_expected.to eq("Flat rate") }
-      end
+      it_behaves_like 'a calculator with a description'
 
       it 'always returns the same rate' do
         expect(subject.compute(build(:stock_package_fulfilled))).to eql 4.00

core/spec/models/spree/calculator/shipping/flexi_rate_spec.rb

@@ -1,15 +1,13 @@
 require 'spec_helper'
+require 'shared_examples/calculator_shared_examples'
 
 module Spree
   module Calculator::Shipping
     describe FlexiRate, type: :model do
       let(:variant1) { build(:variant, price: 10) }
       let(:variant2) { build(:variant, price: 20) }
 
-      describe ".description" do
-        subject { described_class.description }
-        it { is_expected.to eq("Flexible Rate per package item") }
-      end
+      it_behaves_like 'a calculator with a description'
 
       let(:package) do
         build(:stock_package, variants_contents: { variant1 => 4, variant2 => 6 })

core/spec/models/spree/calculator/shipping/per_item_spec.rb

@@ -1,15 +1,13 @@
 require 'spec_helper'
+require 'shared_examples/calculator_shared_examples'
 
 module Spree
   module Calculator::Shipping
     describe PerItem, type: :model do
       let(:variant1) { build(:variant) }
       let(:variant2) { build(:variant) }
 
-      describe ".description" do
-        subject { described_class.description }
-        it { is_expected.to eq("Flat rate per package item") }
-      end
+      it_behaves_like 'a calculator with a description'
 
       let(:package) do
         build(:stock_package, variants_contents: { variant1 => 5, variant2 => 3 })

core/spec/models/spree/calculator/shipping/price_sack_spec.rb

@@ -1,4 +1,5 @@
 require 'spec_helper'
+require 'shared_examples/calculator_shared_examples'
 
 describe Spree::Calculator::Shipping::PriceSack, type: :model do
   let(:calculator) do
@@ -9,10 +10,7 @@
     calculator
   end
 
-  describe ".description" do
-    subject { described_class.description }
-    it { is_expected.to eq("Price sack") }
-  end
+  it_behaves_like 'a calculator with a description'
 
   let(:order) { stub_model(Spree::Order) }
   let(:shipment) { stub_model(Spree::Shipment, amount: 10) }

core/spec/models/spree/calculator/tiered_flat_rate_spec.rb

@@ -1,12 +1,10 @@
 require 'spec_helper'
+require 'shared_examples/calculator_shared_examples'
 
 describe Spree::Calculator::TieredFlatRate, type: :model do
   let(:calculator) { Spree::Calculator::TieredFlatRate.new }
 
-  describe ".description" do
-    subject { described_class.description }
-    it { is_expected.to eq("Tiered Flat Rate") }
-  end
+  it_behaves_like 'a calculator with a description'
 
   describe "#valid?" do
     subject { calculator.valid? }

core/spec/models/spree/calculator/tiered_percent_spec.rb

@@ -1,12 +1,10 @@
 require 'spec_helper'
+require 'shared_examples/calculator_shared_examples'
 
 describe Spree::Calculator::TieredPercent, type: :model do
   let(:calculator) { Spree::Calculator::TieredPercent.new }
 
-  describe ".description" do
-    subject { described_class.description }
-    it { is_expected.to eq("Tiered Percent") }
-  end
+  it_behaves_like 'a calculator with a description'
 
   describe "#valid?" do
     subject { calculator.valid? }

core/spec/shared_examples/calculator_shared_examples.rb

@@ -0,0 +1,8 @@
+shared_examples_for 'a calculator with a description' do
+  describe ".description" do
+    subject { described_class.description }
+    it "has a description" do
+      expect(subject.size).to be > 0
+    end
+  end
+end