Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NH-27837: arm support + verify_install script #24

Merged
merged 13 commits into from
Jan 18, 2023
Merged

Conversation

xuan-cao-swi
Copy link
Contributor

@xuan-cao-swi xuan-cao-swi commented Jan 10, 2023

Why?

Trimmed pr version only for verify_install script and extconf.rb change.

Extra

Successful verify install gha here

@xuan-cao-swi xuan-cao-swi requested a review from a team January 10, 2023 14:26
Copy link
Contributor

@cheempz cheempz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great foundation @xuan-cao-swi. I left several comments, and one more ask: is it possible to add a RedHat 8 image to the mix? https://developers.redhat.com/blog/2020/03/24/red-hat-universal-base-images-for-docker-users#

@xuan-cao-swi
Copy link
Contributor Author

Great foundation @xuan-cao-swi. I left several comments, and one more ask: is it possible to add a RedHat 8 image to the mix? https://developers.redhat.com/blog/2020/03/24/red-hat-universal-base-images-for-docker-users#

Yes, I can try on redhat image from https://hub.docker.com/r/redhat/ubi8

@xuan-cao-swi
Copy link
Contributor Author

@cheempz
I tried the redhat/ubi8 and redhat/ubi9, and I couldn't install solarwinds_apm on them with system ruby no with rbenv ruby.
Do people have to pay to use full version of redhat? because when I tried to install the development tools, it shows following msg.

[root@0035e7ab1e6e /]# yum groupinstall 'Development Tools' -y
Unable to read consumer identity
Subscription Manager is operating in container mode.

This system is not registered with an entitlement server. You can use subscription-manager to register.

@cheempz
Copy link
Contributor

cheempz commented Jan 10, 2023

@cheempz I tried the redhat/ubi8 and redhat/ubi9, and I couldn't install solarwinds_apm on them with system ruby no with rbenv ruby. Do people have to pay to use full version of redhat? because when I tried to install the development tools, it shows following msg.

[root@0035e7ab1e6e /]# yum groupinstall 'Development Tools' -y
Unable to read consumer identity
Subscription Manager is operating in container mode.

This system is not registered with an entitlement server. You can use subscription-manager to register.

Indeed when I run yum grouplist in a redhat/ubi8 container no groups are listed. But the individual packages like gcc-c++, make, etc are available and installable.

@cheempz cheempz self-requested a review January 13, 2023 21:44
cheempz
cheempz previously approved these changes Jan 13, 2023
Copy link
Contributor

@cheempz cheempz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the revisit @xuan-cao-swi! I left a couple comments that can be addressed in a follow-on PR, since it seems you intend to add our own ubi8 image as a next step. I assume that would also allow removing the duplicate set of "ubi" jobs.

Copy link
Contributor

@cheempz cheempz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @xuan-cao-swi!

@xuan-cao-swi xuan-cao-swi merged commit 486c501 into main Jan 18, 2023
@cheempz cheempz deleted the NH-27837-d branch August 3, 2023 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants