-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NH-27837: arm support + verify_install script #24
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great foundation @xuan-cao-swi. I left several comments, and one more ask: is it possible to add a RedHat 8 image to the mix? https://developers.redhat.com/blog/2020/03/24/red-hat-universal-base-images-for-docker-users#
Yes, I can try on redhat image from https://hub.docker.com/r/redhat/ubi8 |
@cheempz
|
Indeed when I run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the revisit @xuan-cao-swi! I left a couple comments that can be addressed in a follow-on PR, since it seems you intend to add our own ubi8
image as a next step. I assume that would also allow removing the duplicate set of "ubi" jobs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @xuan-cao-swi!
Why?
Trimmed pr version only for verify_install script and extconf.rb change.
Extra
Successful verify install gha here