This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Cli: Update OutputFormat method to return a String to restore consistency #9904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-nelson
previously requested changes
May 6, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! These have bothered me for awhile
t-nelson
previously approved these changes
May 6, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Thanks!
💔 Unable to automerge due to CI failure |
💔 Unable to automerge due to CI failure |
Codecov Report
@@ Coverage Diff @@
## master #9904 +/- ##
========================================
- Coverage 80.5% 80.3% -0.2%
========================================
Files 283 283
Lines 65654 65642 -12
========================================
- Hits 52858 52772 -86
- Misses 12796 12870 +74 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The Cli
process_command()
method returns a String, which is printed in main.rs. In times past, every cli method populated this String, but as users wanted more complex and informative prints, they implemented those prints in the respectiveprocess_
method and returnedOk("".to_string())
to main.rs.However, #9478 implemented Display for most of these complex prints, providing the opportunity to re-populate those empty Strings.
Summary of Changes
process_command()
Enables #9650 without the duplicated signature-prints