-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Rpc: Add getConfirmedSignaturesForAddress #9407
Rpc: Add getConfirmedSignaturesForAddress #9407
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9407 +/- ##
========================================
- Coverage 81.1% 81.1% -0.1%
========================================
Files 276 276
Lines 62223 62351 +128
========================================
+ Hits 50519 50622 +103
- Misses 11704 11729 +25 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs a API doc update.
I'm not able to sanely parse the name getAddressConfirmedSignatures
. WDYT about getConfirmedSignaturesForAddress
?
Overall the implementation itself looks great to me though
e39dee5
to
4d1ffa2
Compare
@mvines , ready for another look. |
Only requiring |
The optional So I'd like to leave |
automerge (cherry picked from commit 91159ea)
automerge (cherry picked from commit 91159ea)
Problem
For the history that an API node maintains, it's not possible to fetch the list of transactions that affect a given address. Now that we index signatures by address, the next step would be to return those signatures
Summary of Changes
getConfirmedSignaturesforAddress
rpc endpoint to expose signatures-by-address dataFixes #9317