This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Updates to dynamic-network-test to start validators in parallel #722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeyakovenko
reviewed
Jul 21, 2018
| Some(leader_data.contact_info.ncp), | ||
| ); | ||
| info!("started[{}/{}] {:x}", n, N, rd.debug_id()); | ||
| (rd, val) |
There was a problem hiding this comment.
Checkout into_par_iter
https://github.com/solana-labs/solana/blob/master/src/bin/client-demo.rs#L131
It’s part rayon
There was a problem hiding this comment.
Thanks @aeyakovenko , that made it really simple.
aeyakovenko
reviewed
Jul 21, 2018
| let validator = TestNode::new_localhost_with_pubkey(keypair.pubkey()); | ||
| let rd = validator.data.clone(); | ||
| //send some tokens to the new validator | ||
| let bal = send_tx_and_retry_get_balance( |
There was a problem hiding this comment.
I would do this part first, before starting any validators, make sure their keys are valid and have a balance.
There was a problem hiding this comment.
You mean, transfer balance to all validators, before any of them is started?
There was a problem hiding this comment.
yea, basically do all the prep work before any of them are started so start should be fast
behzadnouri
pushed a commit
to behzadnouri/solana
that referenced
this pull request
Apr 11, 2024
buffalojoec
pushed a commit
to buffalojoec/solana
that referenced
this pull request
Apr 16, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.