This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Get blockhash every batch and don't wait for tx threads #3994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brooksprumo
pushed a commit
to brooksprumo/solana
that referenced
this pull request
Dec 11, 2024
jstarry
added a commit
to jstarry/solana
that referenced
this pull request
Jan 6, 2025
jstarry
added a commit
to jstarry/solana
that referenced
this pull request
Jan 6, 2025
t-nelson
pushed a commit
to t-nelson/solana
that referenced
this pull request
Jan 11, 2025
… and solana-labs#3994) (solana-labs#4297) * feat: deplete compute meter for vm errors (solana-labs#3751) * feat: deplete compute meter for vm errors * add tests * rekey apply_cost_tracker_during_replay (cherry picked from commit b120fc1) * fix Cargo.lock * fix test * cargo lock * fix test * v2.1: feat: deplete compute meter for vm errors (backport of solana-labs#3751) * cargo.lock --------- Co-authored-by: Brennan <brennan.watt@anza.xyz>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
As bench-tps does bench-exchange waits for the transaction transfer threads to finish before generating new transactions. This is unnecessary and just slows down the creation of new transactions for no reason. Transaction generation is already throttled by the trade_delay knob.
Also, an earlier optimization has turned out to cause blockhash errors. When signing transactions new blockhashes were only obtained every x seconds (was 60, then 30). The bench is loading the network so much that there is a large lag in transactions and blockhashes were expiring.
Summary of Changes
Fixes #3979