Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

Use latest release for testnet doc #3711

Merged
merged 3 commits into from
Apr 10, 2019
Merged

Conversation

danpaul000
Copy link
Contributor

Problem

Testnet participation document references a static release (0.12.4)

Summary of Changes

Direct users to the latest release tag to download the binaries or source tarball

Fixes #3603

@danpaul000 danpaul000 requested review from mvines and pgarg66 April 10, 2019 18:23
@danpaul000
Copy link
Contributor Author

This should work on master, but I feel like the user's flow is awkward. It would be a lot cleaner if we can turn on the github api (currently not hooked up on our repo), which provides a link to the "latest" release, and its associated download artifacts, which would be a much cleaner way to access things and keep a command line only unambiguous instruction set.

@mvines
Copy link
Contributor

mvines commented Apr 10, 2019

We do have a nicer solution with solana-install, described at https://solana-labs.github.io/book-edge/installer.html#fetch-and-run-a-pre-built-installer-using-a-bootstrap-curlshell-script and is mostly implemented already (little bit of remaining work to do at #3261).

Prebuilt binaries are available for Linux x86_64 systems. Download and install by running:
##### Download Prebuilt Binaries
Binaries are available for Linux x86_64 systems. Download the binaries by navigating to:
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like CI is red because mdbook thinks that these blocks is Rust source code that needs to be compiled and checked. Maybe drop the ``` for a slightly different format

@danpaul000 danpaul000 merged commit e6f02d1 into solana-labs:master Apr 10, 2019
@danpaul000 danpaul000 deleted the book branch April 10, 2019 22:01
yihau pushed a commit to yihau/solana that referenced this pull request Nov 20, 2024
#### Problem

`solana-instruction` doesn't currently build without the `std` feature,
because the feature gates usage of `Pubkey` and `Vec`.

#### Summary of changes

Always bring in `Pubkey`, gate `BorrowedInstruction` on the `std`
feature.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants