This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Make check{2,3} faster by enabling parallel rustc for dcou #34739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yihau
approved these changes
Jan 11, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
dcou needs some bruteforce compilation for every crates to circumvent cargo's feature unification for its intended functioning. so, it's slow. and people (including me) are starting to be frustrated about it.
Summary of Changes
use recent rust's parallelization for front-end. this is especially effective, because the dcou check only doesn't care about generating binaries.
https://blog.rust-lang.org/2023/11/09/parallel-rustc.html
results (15%-25% faster):
before (taken from #34732):
buildkite/solana/checks2 Passed (7 minutes)
buildkite/solana/checks3 Passed (14 minutes, 50 seconds)
after:
buildkite/solana/checks2 Passed (5 minutes, 55 seconds)
buildkite/solana/checks3 Passed (10 minutes, 52 seconds)
related: #32169