Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

GitHub workflows: Disable cron schedule for forks #34703

Merged
merged 1 commit into from
Jan 10, 2024
Merged

GitHub workflows: Disable cron schedule for forks #34703

merged 1 commit into from
Jan 10, 2024

Conversation

ilya-bobyr
Copy link
Contributor

Problem

Forks will run all the cron schedules. And I do not think they benefit from those. For the downstream project checks, these runs are actually very expensive - about an hour of run time per execution. Easily draining free account limits.

Solution

Disable jobs that run on cron schedules, except for the main repo.


I am not 100% sure this is the best solution.
But this is what I was able to figure out base on some online discussions.
I do not think anyone wants to run this in their forks?
But if they do, they would need to carry a local patch.

@ilya-bobyr ilya-bobyr requested review from joncinque and yihau January 9, 2024 01:25
Copy link
Contributor

@yihau yihau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me! my only concern is the title of this PR :trollface:

Forks will run all the cron schedules.  And I do not think they benefit
from those.  For the downstream project checks, these runs are actually
very expensive - about an hour of run time per execution.  Easily
draining free account limits.
Copy link
Contributor

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same thoughts as Yihau

@ilya-bobyr ilya-bobyr changed the title ledger/blockstore: Use u32 for shred indices. GitHub workflows: Disable cron schedule for forks Jan 10, 2024
@ilya-bobyr
Copy link
Contributor Author

Fixed the title.
Sorry, GitHub picked up a title from the first pushed commit %)

@ilya-bobyr ilya-bobyr merged commit c5d51ac into solana-labs:master Jan 10, 2024
16 checks passed
@ilya-bobyr ilya-bobyr deleted the pr/disable-cron-for-forks branch January 10, 2024 00:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants