This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
ledger-tool: Use OutputFormat printer in program subcommand #34475
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
solana-ledger-tool program
subcommand usessolana_cli_output::OutputFormat
, but uses its own custom printer for no reason.Summary of Changes
Use OutputFormat::formatted_string() to make usage more consistent
No functional changes, except that the order of fields for OutputFormat::JsonCompact changes slightly, due to using
serde_json::to_value(item).unwrap().to_string()
under the hood (instead ofserde_json::to_string(&output).unwrap()
). We don't guarantee the order of json fields, so this change should be non-breaking.