Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

remove unused imports #34467

Merged
merged 1 commit into from
Dec 14, 2023
Merged

remove unused imports #34467

merged 1 commit into from
Dec 14, 2023

Conversation

yihau
Copy link
Contributor

@yihau yihau commented Dec 14, 2023

Problem

Screenshot 2023-12-15 at 01 51 52

Summary of Changes

remove the unused imports.

@yihau yihau requested a review from CriesofCarrots December 14, 2023 17:57
Copy link
Contributor

@CriesofCarrots CriesofCarrots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any idea why CI didn't catch this on the PR?
#34359
cc @taozhu-chicago

@yihau
Copy link
Contributor Author

yihau commented Dec 14, 2023

it passed check. I'm going to merge it on red!

@CriesofCarrots I'm guessing Tao's branch doesn't really rebase the latest master 🤔 he had some changes in the same file these days.

(maybe a before merge test can save us here. iirc the merge queue can do it!)

@yihau yihau merged commit 5b1aa63 into solana-labs:master Dec 14, 2023
19 checks passed
@yihau yihau deleted the fix-ci branch December 14, 2023 18:12
@tao-stones
Copy link
Contributor

it passed check. I'm going to merge it on red!

@CriesofCarrots I'm guessing Tao's branch doesn't really rebase the latest master 🤔 he had some changes in the same file these days.

(maybe a before merge test can save us here. iirc the merge queue can do it!)

I think I rebased master before commit, but I could be wrong. Maybe the PR waited long enough time between CI green and approval/merge?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants