Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

Moves val into .extend() instead of &mut and .into_iter() #34285

Merged
merged 1 commit into from
Dec 1, 2023
Merged

Moves val into .extend() instead of &mut and .into_iter() #34285

merged 1 commit into from
Dec 1, 2023

Conversation

brooksprumo
Copy link
Contributor

Originally from #34280 (comment), this is a simple cleanup. We can pass the results.skipped_rewrites directly into .extend(), instead of doing the &mut + .into_iter().

@brooksprumo brooksprumo self-assigned this Nov 30, 2023
@brooksprumo brooksprumo mentioned this pull request Nov 30, 2023
Merged
@brooksprumo brooksprumo marked this pull request as ready for review November 30, 2023 18:45
HaoranYi
HaoranYi approved these changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@HaoranYi HaoranYi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice use of move.
lgtm.

jeffwashington
jeffwashington approved these changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@jeffwashington jeffwashington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@brooksprumo brooksprumo merged commit 8fbe033 into solana-labs:master Dec 1, 2023
18 checks passed
@brooksprumo brooksprumo deleted the skipped-rewrite-cleanup branch December 1, 2023 19:38
@willhickey willhickey mentioned this pull request Mar 28, 2024
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jeffwashington jeffwashington jeffwashington approved these changes

@HaoranYi HaoranYi HaoranYi approved these changes

Assignees

@brooksprumo brooksprumo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brooksprumo @HaoranYi @jeffwashington