Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

Update CHANGELOG for new scheduler support #34181

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

apfitzge
Copy link
Contributor

Problem

I did not update the CHANGELOG in #33890, which enabled this option, because I was waiting to merge a few metrics PRs first.
Those have been merged, so updating the change log now.

Summary of Changes

Add changelog line which lists new --block-production-method central-scheduler option

Fixes #

@apfitzge apfitzge requested a review from tao-stones November 20, 2023 20:16
tao-stones
tao-stones previously approved these changes Nov 20, 2023
Copy link
Contributor

@tao-stones tao-stones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, nice!

@apfitzge apfitzge requested a review from willhickey November 20, 2023 22:15
willhickey
willhickey previously approved these changes Nov 27, 2023
Copy link
Contributor

@willhickey willhickey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@apfitzge
Copy link
Contributor Author

Had to push a fix for conflict with #34228. @taozhu-chicago or @willhickey could I get re-approval on this?

@apfitzge apfitzge dismissed stale reviews from willhickey and tao-stones via 1de5b32 November 27, 2023 20:15
@tao-stones
Copy link
Contributor

33 files changed 😱

@apfitzge apfitzge force-pushed the scheduler-change-log branch from 21aaf6e to 1de5b32 Compare November 27, 2023 20:20
@apfitzge
Copy link
Contributor Author

33 files changed 😱

? It should be a +1 change. Maybe it was displaying incorrectly after rebase due to the github issues today: https://www.githubstatus.com/incidents/66vhjmd266r9

Appears to have been resolved now.

Copy link
Contributor

@tao-stones tao-stones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm (again:D)

@apfitzge apfitzge added the automerge Merge this Pull Request automatically once CI passes label Nov 27, 2023
@mergify mergify bot merged commit 564f1a9 into solana-labs:master Nov 27, 2023
2 checks passed
@apfitzge apfitzge deleted the scheduler-change-log branch November 27, 2023 23:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
automerge Merge this Pull Request automatically once CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants