Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

Added a comment about order of dropping plugin and library #34160

Merged
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions geyser-plugin-manager/src/geyser_plugin_manager.rs
Original file line number Diff line number Diff line change
Expand Up @@ -221,6 +221,7 @@ impl GeyserPluginManager {
let mut current_plugin = self.plugins.remove(idx);
let name = current_plugin.name().to_string();
current_plugin.on_unload();
// The plugin must be first dropped before dropping the library to avoid crash.
lijunwangs marked this conversation as resolved.
Show resolved Hide resolved
drop(current_plugin);
drop(current_lib);
info!("Unloaded plugin {name} at idx {idx}");
Expand Down