This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Move RPC root check to underlying Blockstore functions #33991
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@steviez , should we reopen this? Can't remember if we ever discussed it |
Yeah definitely; when I was last looking at it, I discovered a secondary issue and then other stuff came up. Still on my backlog tho and reopening |
|
Actually, I still have the GH issues for tracking work so I'm going to let this PR close out; I already see a merge conflict and re-approaching this problem with a fresh view could be beneficial. For the sake of paper-trail, the GH issues related to the work this PR was looking to address are #33859 AND #33858 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
getBlockandgetBlockTimemethods perform several checks to return a proper error when commitment levelfinalizedis passed. Currently, most of these checks occur within the underlyingBlockstoremethods, but one of these checks occurs inrpc.rs. It would be better to have all of the checks in the same location.Summary of Changes
Move the logic that checks whether a requested slot exceeds the
Blockstore's maximum root fromJsonRpcRequestProcessortoBlockstore. The result is that the previous function inJsonRpcRequestProcessorsimply translatesBlockstoreErrorto the appropriate RPC error type.This is a spin out from #33901 (comment).