This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Fastboots by default #33883
Merged
Fastboots by default #33883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f651b33 to
35aa40b
Compare
Codecov Report
@@ Coverage Diff @@
## master #33883 +/- ##
=======================================
Coverage 81.8% 81.9%
=======================================
Files 810 811 +1
Lines 218148 218163 +15
=======================================
+ Hits 178650 178721 +71
+ Misses 39498 39442 -56 |
35aa40b to
567342f
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Fastboot is available as a CLI arg, but it's not on by default. This means most validators will not use it/know about it.
Summary of Changes
Turn on fastboot by default.
Note that fastboot was properly added/supported in v1.17. Turning it on by default is v1.18+. This will allow for testing from a wider audience as v1.17 is rolled out to the various clusters.