This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Correct num_packets stats #33630
Merged
Correct num_packets stats #33630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ff78f0d to
253bf0b
Compare
Codecov Report
@@ Coverage Diff @@
## master #33630 +/- ##
=======================================
Coverage 81.8% 81.8%
=======================================
Files 806 806
Lines 217499 217502 +3
=======================================
+ Hits 178019 178073 +54
+ Misses 39480 39429 -51 |
pgarg66
approved these changes
Oct 11, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The num_packets stats are counting the empty packets which are not actually sent and hence skewing the relationship between num_packets and successful_packets
Summary of Changes
Do not count the empty packets from cache warmer in num_packets stats as they are not sent.
Fixes #