This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Fix: handle -- --target-dir arg in cargo build-sbf
#33555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmakarov
previously approved these changes
Oct 6, 2023
Codecov Report
@@ Coverage Diff @@
## master #33555 +/- ##
=======================================
Coverage 81.7% 81.7%
=======================================
Files 805 805
Lines 218162 218162
=======================================
+ Hits 178410 178418 +8
+ Misses 39752 39744 -8 |
dmakarov
approved these changes
Oct 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently, extra args are allowed to pass through
cargo build-sbfto cargo build. However, the--target-dirarg isn't being handled properly, and results in invalid file paths being used when target-dir is in play.Summary of Changes
This PR intercepts --target-dir in the remaining args, canonicalizes it to fix issues with workspace relative paths, and adds it to the config to be used as the new target dir.