Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

dcou: make internal function pub conditionally #32822

Merged
merged 1 commit into from
Aug 13, 2023

Conversation

ryoqun
Copy link
Contributor

@ryoqun ryoqun commented Aug 12, 2023

context: #32748 (comment)

this is another small pr for the dcou initiative: #32169

@ryoqun ryoqun requested a review from brooksprumo August 12, 2023 13:06
@ryoqun ryoqun changed the title dcou: make internal function pub conditionally dcou: make internal function pub conditionally Aug 12, 2023
@ryoqun ryoqun force-pushed the dcou-conditional-pub branch from 4bda012 to 417ab5c Compare August 12, 2023 13:10
@ryoqun ryoqun force-pushed the dcou-conditional-pub branch from 417ab5c to 778f880 Compare August 12, 2023 13:17
@@ -7898,6 +7900,7 @@ impl AccountsDb {
/// Set the accounts delta hash for `slot` in the `accounts_delta_hashes` map
///
/// returns the previous accounts delta hash for `slot`
#[cfg_attr(feature = "dev-context-only-utils", fn_qualifiers(pub))]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here

@codecov
Copy link

codecov bot commented Aug 12, 2023

Codecov Report

Merging #32822 (778f880) into master (58cca78) will decrease coverage by 0.1%.
The diff coverage is 100.0%.

@@            Coverage Diff            @@
##           master   #32822     +/-   ##
=========================================
- Coverage    82.0%    82.0%   -0.1%     
=========================================
  Files         785      785             
  Lines      211945   211940      -5     
=========================================
- Hits       173860   173840     -20     
- Misses      38085    38100     +15     

Copy link
Contributor

@brooksprumo brooksprumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, this is great! Thanks for finding a solution to this.

I'm approving this PR as-is, but if you'd also be willing to do the same with set_accounts_hash_for_tests() and set_accounts_hash(), that would be much appreciated. Could be in this PR, or a subsequent one. Thank you!

@ryoqun
Copy link
Contributor Author

ryoqun commented Aug 13, 2023

Oh, this is great! Thanks for finding a solution to this.

I'm approving this PR as-is, but if you'd also be willing to do the same with set_accounts_hash_for_tests() and set_accounts_hash(), that would be much appreciated. Could be in this PR, or a subsequent one. Thank you!

thanks for quick approval. I'll create a subsequent one.

@ryoqun ryoqun merged commit ce63640 into solana-labs:master Aug 13, 2023
@brooksprumo
Copy link
Contributor

[..] if you'd also be willing to do the same with set_accounts_hash_for_tests() and set_accounts_hash(), that would be much appreciated

[..] I'll create a subsequent one.

There were a few other changes that needed to happen before set_accounts_hash could get the same treatment, so I'm handling those. Here the PR for the dcou bits: #32829

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants