-
Notifications
You must be signed in to change notification settings - Fork 4.6k
dcou: make internal function pub
conditionally
#32822
Conversation
pub
conditionally
4bda012
to
417ab5c
Compare
417ab5c
to
778f880
Compare
@@ -7898,6 +7900,7 @@ impl AccountsDb { | |||
/// Set the accounts delta hash for `slot` in the `accounts_delta_hashes` map | |||
/// | |||
/// returns the previous accounts delta hash for `slot` | |||
#[cfg_attr(feature = "dev-context-only-utils", fn_qualifiers(pub))] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here
Codecov Report
@@ Coverage Diff @@
## master #32822 +/- ##
=========================================
- Coverage 82.0% 82.0% -0.1%
=========================================
Files 785 785
Lines 211945 211940 -5
=========================================
- Hits 173860 173840 -20
- Misses 38085 38100 +15 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, this is great! Thanks for finding a solution to this.
I'm approving this PR as-is, but if you'd also be willing to do the same with set_accounts_hash_for_tests()
and set_accounts_hash()
, that would be much appreciated. Could be in this PR, or a subsequent one. Thank you!
thanks for quick approval. I'll create a subsequent one. |
There were a few other changes that needed to happen before |
context: #32748 (comment)
this is another small pr for the dcou initiative: #32169