This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
correctly log stats at remove_unrooted_slots #32467
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
During high account count testing, we discovered
remove_unrooted_slots
taking a very long time (hours).Unfortunately, the log metrics had a bug in when to log the metrics. The metric logging code is shared. In this case, the metrics are created new each call. This means the first time to check if sufficient duration has passed will ALWAYS skip the first call and say 'no'. This prevents startup noise and gives periodic, useful metrics over time. However, in this case since we never call it a second time on the same temporary metrics struct, the metrics NEVER get logged. This is related to the skip first parameter within the elapsed time checker.
Summary of Changes
Change duration to None so that we always log the metrics NOW, the one and only time it is called from abs loop.
Fixes #