This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Explain use of nightly clippy over whole monorepo #31833
+8
−2
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -77,7 +77,12 @@ _ ci/order-crates-for-publishing.py | |||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
| nightly_clippy_allows=(--allow=clippy::redundant_clone) | ||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
| # use nightly clippy as frozen-abi proc-macro generates a lot of code across | ||||||||||||||||||||||||||
| # various crates in this whole mono-repo. Likewise, frozen-abi(-macro) crates' | ||||||||||||||||||||||||||
| # unit tests are only compiled under nightly. | ||||||||||||||||||||||||||
| # similarly nightly is desired to run clippy over all of bench files because | ||||||||||||||||||||||||||
| # the bench itself isn't stabilized yet... | ||||||||||||||||||||||||||
| # ref: https://github.com/rust-lang/rust/issues/66287 | ||||||||||||||||||||||||||
|
There was a problem hiding this comment.
Suggested change
Comment nits There was a problem hiding this comment. It's not clear from this comment why "frozen-abi proc-macro generating code" necessitates nightly clippy. Can you expand? There was a problem hiding this comment. hehe, nice question. how about this?: dda0127 There was a problem hiding this comment.
Much better, thank you! |
||||||||||||||||||||||||||
| _ scripts/cargo-for-all-lock-files.sh -- "+${rust_nightly}" clippy --workspace --all-targets --features dummy-for-ci-check -- \ | ||||||||||||||||||||||||||
| --deny=warnings \ | ||||||||||||||||||||||||||
| --deny=clippy::default_trait_access \ | ||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the
./sdkreference was arguably staleas a matter of fact, this particular line is added at #8012 (comment) but frozen abi is moved out of
./sdkat #13008