Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

Refactor: Rename load_transaction to load_transaction_accounts #28746

Merged
merged 2 commits into from
Nov 18, 2022

Conversation

jstarry
Copy link
Contributor

@jstarry jstarry commented Nov 4, 2022

Summary of Changes

  • Rename load_transaction to load_transaction_accounts
  • Removed nesting layer to improve readability

@jstarry jstarry added the automerge Merge this Pull Request automatically once CI passes label Nov 4, 2022
@mergify mergify bot removed the automerge Merge this Pull Request automatically once CI passes label Nov 4, 2022
@mergify
Copy link
Contributor

mergify bot commented Nov 4, 2022

automerge label removed due to a CI failure

@jstarry jstarry force-pushed the refactor/load-transaction branch from 1fc0bf1 to 7fbd290 Compare November 15, 2022 09:45
@jstarry jstarry requested a review from Lichtso November 15, 2022 09:46
@jstarry
Copy link
Contributor Author

jstarry commented Nov 15, 2022

@Lichtso do you mind looking this over? You'll want to hide whitespace to see the diff. Motivation for this change is to improve readability

@jstarry jstarry added the automerge Merge this Pull Request automatically once CI passes label Nov 17, 2022
@mergify mergify bot removed the automerge Merge this Pull Request automatically once CI passes label Nov 17, 2022
@mergify
Copy link
Contributor

mergify bot commented Nov 17, 2022

automerge label removed due to a CI failure

@jstarry jstarry merged commit 4c85850 into solana-labs:master Nov 18, 2022
@jstarry jstarry deleted the refactor/load-transaction branch November 18, 2022 15:44
gnapoli23 pushed a commit to gnapoli23/solana that referenced this pull request Dec 16, 2022
…olana-labs#28746)

* Refactor: Rename load_transaction to load_transaction_accounts

* Refactor: map over account keys to load transaction accounts
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants