This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Use serde provided serialization for atomics #10096
Merged
solana-grimes
merged 2 commits into
solana-labs:master
from
svenski123:use-atomic-serde
May 18, 2020
Merged
Use serde provided serialization for atomics #10096
solana-grimes
merged 2 commits into
solana-labs:master
from
svenski123:use-atomic-serde
May 18, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… functionality already provided by serde
horray for working on this quickly! @svenski123 it seems that our ci doesn't like empty files... I think this file can just completely go away and put snapshot versioned code in |
Ah, also if you're bothered with rebasing in general. Please feel free to to any |
ryoqun
approved these changes
May 18, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really thank you!
Codecov Report
@@ Coverage Diff @@
## master #10096 +/- ##
=======================================
Coverage 81.5% 81.5%
=======================================
Files 283 282 -1
Lines 65930 65904 -26
=======================================
- Hits 53785 53765 -20
+ Misses 12145 12139 -6 |
This was referenced Oct 11, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use serde provided functions for serializing / deserializing atomics instead of the functions in serde_utils which are functionally equivalent.
Remove unused functions in serde_utils.
Note serde_utils.rs is left as an empty file for other PRs that will add to it.