Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

Commission decrease should be allowed at any time #33843

Closed
bji opened this issue Oct 24, 2023 · 1 comment · Fixed by #33847
Closed

Commission decrease should be allowed at any time #33843

bji opened this issue Oct 24, 2023 · 1 comment · Fixed by #33847
Labels
community Community contribution

Comments

@bji
Copy link
Contributor

bji commented Oct 24, 2023

Problem

The commission_updates_only_allowed_in_first_half_of_epoch feature disallows commission decrease in the second half of epoch. Given that the purpose of this feature was to prevent 'rug pulls' which are accomplished by increasing commission at the end of epoch and then decreasing commission at the beginning of next epoch, disallowing decreases during the second half of epoch is unnecessary.

Disallowing commission decreases in the second half of epoch prevents an operational technique that I use with my validator: when I have an operator error that results in reduced stake account rewards for the epoch, I reduce commission to 0% to ensure that stake accounts are not disadvantaged by my actions. Not being allowed to do this in the second half of an epoch is a real problem for me.

Proposed Solution

Add a feature which will enable set-commission logic to first check whether the proposed commission change is a decrease, and if so, do not invoke the "only allow commission change in first half of epoch" rule.

@bji bji added the community Community contribution label Oct 24, 2023
bji added a commit to bji/solana that referenced this issue Oct 24, 2023
vote account commission to be lowered at any time during the epoch
regardless of the commission_updates_only_allowed_in_first_half_of_epoch
feature.  Fixes solana-labs#33843.
bji added a commit to bji/solana that referenced this issue Oct 24, 2023
vote account commission to be lowered at any time during the epoch
regardless of the commission_updates_only_allowed_in_first_half_of_epoch
feature.  Fixes solana-labs#33843.
bji added a commit to bji/solana that referenced this issue Oct 24, 2023
vote account commission to be lowered at any time during the epoch
regardless of the commission_updates_only_allowed_in_first_half_of_epoch
feature.  Fixes solana-labs#33843.
bji added a commit to bji/solana that referenced this issue Oct 26, 2023
vote account commission to be lowered at any time during the epoch
regardless of the commission_updates_only_allowed_in_first_half_of_epoch
feature.  Fixes solana-labs#33843.

SIMD: 0080
@joncinque
Copy link
Contributor

The feature gate issue to track this is #33994

bji added a commit to bji/solana that referenced this issue Nov 17, 2023
vote account commission to be lowered at any time during the epoch
regardless of the commission_updates_only_allowed_in_first_half_of_epoch
feature.  Fixes solana-labs#33843.

SIMD: 0080
bji added a commit to bji/solana that referenced this issue Nov 17, 2023
vote account commission to be lowered at any time during the epoch
regardless of the commission_updates_only_allowed_in_first_half_of_epoch
feature.  Fixes solana-labs#33843.

SIMD: 0080
AshwinSekar pushed a commit that referenced this issue Dec 8, 2023
…33847)

* Add allow_commission_decrease_at_any_time feature which will allow
vote account commission to be lowered at any time during the epoch
regardless of the commission_updates_only_allowed_in_first_half_of_epoch
feature.  Fixes #33843.

SIMD: 0080

* Remove unused `feature_set` import

---------

Co-authored-by: Jon Cinque <me@jonc.dev>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
community Community contribution
Projects
None yet
2 participants