This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
Add fromJson and toJson options to HTTP transport
#3192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ea59901 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This was referenced Sep 2, 2024
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @lorisleiva and the rest of your teammates on |
This was referenced Sep 2, 2024
2e132bb to
6d224dd
Compare
8027ee8 to
eec29ad
Compare
6d224dd to
56c4dbc
Compare
eec29ad to
4272a4f
Compare
56c4dbc to
4430dda
Compare
4272a4f to
d9ab449
Compare
4430dda to
dd8d6b7
Compare
d9ab449 to
915b51e
Compare
dd8d6b7 to
70bfa6f
Compare
915b51e to
961ef97
Compare
70bfa6f to
3a681f1
Compare
961ef97 to
0690002
Compare
steveluscher
suggested changes
Sep 9, 2024
Comment on lines
71
to
73
| statusCode: response.status, | ||
| }); | ||
| } | ||
| if (fromJson) { | ||
| return fromJson(await response.text(), { methodName, params }) as TResponse; | ||
| } |
There was a problem hiding this comment.
[Re: lines +53 to +76]
Commented [here](https://app.graphite.dev/github/pr/solana-labs/solana-web3.js/3186/Make-RPC-transports-responsible-for-preparing-payloads#review-PRR_kwDOCLAddc6IhmFq). I think the base-level transport shouldn't know anything about JavaScript or JSON; it should just accept and return text.
See this comment inline on Graphite.
Commented [here](https://app.graphite.dev/github/pr/solana-labs/solana-web3.js/3186/Make-RPC-transports-responsible-for-preparing-payloads#review-PRR_kwDOCLAddc6IhmFq). I think the base-level transport shouldn't know anything about JavaScript or JSON; it should just accept and return text.
See this comment inline on Graphite.
23f22d1 to
f62ca3a
Compare
21ecd67 to
44d491d
Compare
44d491d to
ea59901
Compare
Merge activity
|
Merged
|
Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two new optional functions to the
createHttpTransportconfigs.fromJson: When provided, replaces the logic that transforms the response from a JSON string into a JSON value.toJson: When provided, replaces the logic that transforms the request payload from a JSON value into a JSON string.This will enable us to wrap this transport and create a new Solana-RPC-specific HTTP transport that do not loose range/precision when
bigintvalues are transmitted over the wire.