Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

Add minContextSlot as an option to Transaction{Sending}SignerConfig #2858

Conversation

steveluscher
Copy link
Contributor

Summary

Instead of the cumbersome getOptions() solution that requires callers of the hook to track transaction / context slot pairs and return a getter for them… just add minContextSlot to the options.

Test Plan

pnpm turbo test:unit:node test:unit:browser

Closes #2846

Copy link

changeset-bot bot commented Jun 26, 2024

🦋 Changeset detected

Latest commit: ee304c3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 37 packages
Name Type
@solana/signers Minor
@solana/web3.js-experimental Minor
@solana/react Minor
@solana/accounts Minor
@solana/addresses Minor
@solana/assertions Minor
@solana/codecs-core Minor
@solana/codecs-data-structures Minor
@solana/codecs-numbers Minor
@solana/codecs-strings Minor
@solana/codecs Minor
@solana/compat Minor
@solana/errors Minor
@solana/fast-stable-stringify Minor
@solana/functional Minor
@solana/instructions Minor
@solana/keys Minor
@solana/options Minor
@solana/programs Minor
@solana/rpc-api Minor
@solana/rpc-graphql Minor
@solana/rpc-parsed-types Minor
@solana/rpc-spec-types Minor
@solana/rpc-spec Minor
@solana/rpc-subscriptions-api Minor
@solana/rpc-subscriptions-spec Minor
@solana/rpc-subscriptions-transport-websocket Minor
@solana/rpc-subscriptions Minor
@solana/rpc-transformers Minor
@solana/rpc-transport-http Minor
@solana/rpc-types Minor
@solana/rpc Minor
@solana/sysvars Minor
@solana/transaction-confirmation Minor
@solana/transaction-messages Minor
@solana/transactions Minor
@solana/webcrypto-ed25519-polyfill Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@steveluscher steveluscher marked this pull request as draft June 26, 2024 17:09
@steveluscher steveluscher requested a review from lorisleiva June 26, 2024 17:09
@steveluscher steveluscher force-pushed the 06-26-add_mincontextslot_as_an_option_to_transaction_sending_signerconfig_ branch from 4c64365 to 9ee37a8 Compare June 26, 2024 17:33
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @steveluscher and the rest of your teammates on Graphite Graphite

@steveluscher steveluscher marked this pull request as ready for review June 26, 2024 17:34
@steveluscher steveluscher force-pushed the 06-26-add_mincontextslot_as_an_option_to_transaction_sending_signerconfig_ branch 3 times, most recently from dd1451a to e80060a Compare June 26, 2024 18:03
Copy link
Contributor

@lorisleiva lorisleiva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfection!

@steveluscher steveluscher force-pushed the 06-26-add_mincontextslot_as_an_option_to_transaction_sending_signerconfig_ branch from e80060a to ee304c3 Compare June 26, 2024 19:58
@steveluscher steveluscher added the automerge Merge this Pull Request automatically once CI passes label Jun 26, 2024 — with Graphite App
@mergify mergify bot merged commit 22a34aa into master Jun 26, 2024
7 checks passed
@mergify mergify bot deleted the 06-26-add_mincontextslot_as_an_option_to_transaction_sending_signerconfig_ branch June 26, 2024 20:00
Copy link
Contributor

Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
automerge Merge this Pull Request automatically once CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add minContextSlot into the options of TransactionSendingSignerConfig
2 participants