This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Fix a bug in Node <21 that prevented the normal operation of the request coalescer #2326
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There is a bug in the version of
undici
that ships with Node <21 that throws an unhandled exception when thereason
property of anAbortSignal
is a non-object. The request coalescer hits this bug because it uses aSymbol
to differentiate between an internal abort and a user abort.undici
chokes on thatSymbol
.In this PR we capitulate and change it to an object.
See nodejs/undici#2597 for more detail about the bug.
Test Plan
In every version of Node from 18-21,
undici
handles an object correctly.Resolves #2325.