Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Android): fix sheet transition when there is no dimming applied #2723

Merged
merged 2 commits into from
Feb 20, 2025

Conversation

kkafar
Copy link
Member

@kkafar kkafar commented Feb 20, 2025

Description

Shout out to @kligarski for spotting this out!

I've introduced a regression in 4.7.0 when refactoring sheet animation - basically it always animated to the resolved maxAlpha
for given sheet dimming view & did not take into account sheetLargestUndimmedDetentIndex prop, effectively disabling this prop.

This affects both architectures.

Changes

When configuring enter animation we now take the prop into account.

Test code and steps to reproduce

TestFormSheet

Checklist

  • Included code example that can be used to test this change
  • Ensured that CI passes

@kkafar kkafar requested a review from kligarski February 20, 2025 13:40
Copy link

@kligarski kligarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kkafar kkafar merged commit 1540218 into main Feb 20, 2025
3 of 4 checks passed
@kkafar kkafar deleted the @kkafar/largest-undimmed-detent-does-not-work branch February 20, 2025 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants