fix(Android): fix sheet transition when there is no dimming applied #2723
+23
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Shout out to @kligarski for spotting this out!
I've introduced a regression in 4.7.0 when refactoring sheet animation - basically it always animated to the resolved
maxAlpha
for given sheet dimming view & did not take into account
sheetLargestUndimmedDetentIndex
prop, effectively disabling this prop.This affects both architectures.
Changes
When configuring enter animation we now take the prop into account.
Test code and steps to reproduce
TestFormSheet
Checklist