Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Android): deprecate series of status/navigation bar related props #2638

Merged
merged 5 commits into from
Jan 20, 2025

Conversation

kkafar
Copy link
Member

@kkafar kkafar commented Jan 20, 2025

Description

Important context

For all apps targeting Android SDK 35 the edge-to-edge mode is enabled by default (it is effectively enforced, opting out takes some effort) and everything indicates that it will be enforced in future SDKs.

For SDKs below 35 the status / navigation bar APIs affected by this PR are deprecated or deprecated & disabled (see above links ☝🏻 ).

Currently minimal target sdk level for google app store is 34 (source). We can't really foresee when SDK level 35 will be required, however it can be clearly seen that edge-to-edge will be the promoted and supported way of designing UI on Android.

We want to get rid of these props for one more reason. These are Android-specific props and translucency is implemented by (not) consuming appropriate window insets, which leads to conflicts with other libs and we can't set right defaults, since it is not really possible to detect whether the app is in edge to edge or not leading to some buggy behaviour (initial content jump etc.).

Changes

  • Deprecate navigationBarColor
  • Deprecate navigationBarTranslucent
  • Deprecate statusBarColor
  • Deprecate statusBarTranslucent
  • Deprecate topInsetEnabled

Test code and steps to reproduce

No runtime changes.

Checklist

  • Ensured that CI passes

@kkafar kkafar marked this pull request as ready for review January 20, 2025 12:41
@kkafar kkafar merged commit b69ea04 into main Jan 20, 2025
4 of 5 checks passed
@kkafar kkafar deleted the @kkafar/deprecate-some-android-props branch January 20, 2025 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant