Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add constraints for velocity in goBackGesture screen transition #2061

Merged
merged 2 commits into from
Mar 13, 2024
Merged

fix: Add constraints for velocity in goBackGesture screen transition #2061

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eaf14bf
Add constraints
piaskowyk Mar 7, 2024
b17b83a
Merge branch 'main' into @piaskowyk/improve-gesture-detector
tboba Mar 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/gesture-handler/ScreenGestureDetector.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,8 +183,10 @@ const ScreenGestureDetector = ({

const velocityFactor = 0.3;
const screenSize = screenTransitionConfig.value.screenDimensions;
const distanceX = event.translationX + event.velocityX * velocityFactor;
const distanceY = event.translationY + event.velocityY * velocityFactor;
const distanceX =
event.translationX + Math.min(event.velocityX * velocityFactor, 100);
const distanceY =
event.translationY + Math.min(event.velocityY * velocityFactor, 100);
const requiredXDistance = screenSize.width / 2;
const requiredYDistance = screenSize.height / 2;
const isTransitionCanceled = checkIfTransitionCancelled(
Expand Down
Loading