Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refact: remove mixed CJS/ESM, refactorize index.native.tsx #1982
refact: remove mixed CJS/ESM, refactorize index.native.tsx #1982
Changes from all commits
7e0bf34
340c548
8493f67
9b6bf09
f955f52
ce62286
19e038e
0917432
04d811e
2b872ff
9e12ce0
d61df9b
8075462
ce4b463
6c44ee7
6a46ed4
b84ed00
30873a0
2e3316d
e677024
2cfce53
e67b1ca
a05ce59
8a7da07
381d249
edd2934
52e3078
c175db9
f7ebf18
80db1e2
c48929b
5c3a8cd
38bd695
6c64d70
2a6eedd
f50265b
f62eeb7
989e545
eb3a635
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 10 in src/components/FullWindowOverlay.tsx
Check warning on line 19 in src/components/Screen.tsx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we will remove the
active
prop and code related to it in v4, just a note for future.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks for mentioning that. We can do that in a separate PR 👍
Check warning on line 11 in src/components/ScreenContainer.tsx
Check warning on line 14 in src/components/ScreenContainer.tsx