fix(iOS): Fix conditional rendering on Fabric #1978
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently when user tries to render screen conditionally the blank screen is being rendered.
That's because the screen after the changing state is being recycled, which leads to render UIReplicantView (which is the screen's snapshot) and not refresh push view controllers.
This PR fixes that by resetting view to screen and setting push view controllers when screen is being recycled.
Unfortunately when I was creating this PR I observed several screen blinks during the change of the state. I believe that this could be fixed by introducing @WoLewicki's PR about making view recycling optional (see RN #35378).
Closes #1628.
Changes
mountChildComponentView
that indicates if rendered screen was recycledsetPushViewControllers
when arrays are the sameScreenshots / GIFs
Before 😥
Screen.Recording.2023-11-27.at.11.57.37.mov
After 🤯
Screen.Recording.2023-11-27.at.11.55.08.mov
Test code and steps to reproduce
You can check
TestX
included in this PR to check the changes.Checklist