-
-
Notifications
You must be signed in to change notification settings - Fork 540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: make enabling device orientation notifications internal #1596
fix: make enabling device orientation notifications internal #1596
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great idea to remove this installation step.
I'm leaving a note below - as we talked, so we don't bypass the objections and mistakenly merge it.
RNSScreenWindowTraits I tested it and initialisation code is called as expected -- in the very begining of runtime.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm asking for review, to make sure that there aren't any quirks in view manager's lifecycle.
#if !TARGET_OS_TV | ||
// See: | ||
// 1. https://github.com/software-mansion/react-native-screens/pull/1543 | ||
// 2. https://github.com/software-mansion/react-native-screens/pull/1596 | ||
// This class is instatiated from React Native's internals during application startup | ||
- (instancetype)init | ||
{ | ||
if (self = [super init]) { | ||
dispatch_async(dispatch_get_main_queue(), ^{ | ||
[[UIDevice currentDevice] beginGeneratingDeviceOrientationNotifications]; | ||
}); | ||
} | ||
return self; | ||
} | ||
|
||
- (void)dealloc | ||
{ | ||
dispatch_sync(dispatch_get_main_queue(), ^{ | ||
[[UIDevice currentDevice] endGeneratingDeviceOrientationNotifications]; | ||
}); | ||
} | ||
#endif // !TARGET_OS_TV | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I decided to add this code to RNSScreenManager
.
I'm asking for review, to make sure that there aren't any quirks in view manager's lifecycle.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tbh, I am not familiar with the lifecycle of view managers, did you test how does it work on Fabric?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, I added ad breakpoint at init
method and it got called during initial app loading.
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [react-native-screens](https://togithub.com/software-mansion/react-native-screens) | [`^3.18.2` -> `^3.25.0`](https://renovatebot.com/diffs/npm/react-native-screens/3.18.2/3.25.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/react-native-screens/3.25.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/react-native-screens/3.25.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/react-native-screens/3.18.2/3.25.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/react-native-screens/3.18.2/3.25.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>software-mansion/react-native-screens (react-native-screens)</summary> ### [`v3.25.0`](https://togithub.com/software-mansion/react-native-screens/releases/tag/3.25.0) [Compare Source](https://togithub.com/software-mansion/react-native-screens/compare/3.24.0...3.25.0) #### What's Changed Minor release focused on bug fixes & internals. #### 🐛 Bug fixes - iOS: Add missing call to super method in `RNSScreenView#finalizeUpdates` by [@​kkafar](https://togithub.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1855](https://togithub.com/software-mansion/react-native-screens/pull/1855) - Android: Shorten alpha animation to 83ms on default enter-out by [@​kkafar](https://togithub.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1835](https://togithub.com/software-mansion/react-native-screens/pull/1835) - iOS: Wrong title in back button menu for screens w/ hidden header by [@​kkafar](https://togithub.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1866](https://togithub.com/software-mansion/react-native-screens/pull/1866) - iOS: Full window overlay cannot receive tap when modal is full screen by [@​intergalacticspacehighway](https://togithub.com/intergalacticspacehighway) in [https://github.com/software-mansion/react-native-screens/pull/1872](https://togithub.com/software-mansion/react-native-screens/pull/1872) #### 🔢 Miscellaneous - Reinstall deps & pods in example apps after release by [@​kkafar](https://togithub.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1862](https://togithub.com/software-mansion/react-native-screens/pull/1862) - Fix typo in docs on `sheetCornerRadius` by [@​kkafar](https://togithub.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1863](https://togithub.com/software-mansion/react-native-screens/pull/1863) - Use `PlatformColor` instead of plain `string` for color related props by [@​retyui](https://togithub.com/retyui) in [https://github.com/software-mansion/react-native-screens/pull/1846](https://togithub.com/software-mansion/react-native-screens/pull/1846) - Android: Migrate `replaceSystemWindowInsets` to `Builder.setSystemWindowInsets` by [@​kirillzyusko](https://togithub.com/kirillzyusko) in [https://github.com/software-mansion/react-native-screens/pull/1868](https://togithub.com/software-mansion/react-native-screens/pull/1868) #### New Contributors - [@​intergalacticspacehighway](https://togithub.com/intergalacticspacehighway) made their first contribution in [https://github.com/software-mansion/react-native-screens/pull/1872](https://togithub.com/software-mansion/react-native-screens/pull/1872) - [@​retyui](https://togithub.com/retyui) made their first contribution in [https://github.com/software-mansion/react-native-screens/pull/1846](https://togithub.com/software-mansion/react-native-screens/pull/1846) **Full Changelog**: software-mansion/react-native-screens@3.24.0...3.25.0 ### [`v3.24.0`](https://togithub.com/software-mansion/react-native-screens/releases/tag/3.24.0) [Compare Source](https://togithub.com/software-mansion/react-native-screens/compare/3.23.0...3.24.0) Minor release focused on fixing build issues reported in [#​1859](https://togithub.com/software-mansion/react-native-screens/issues/1859). #### What's Changed #### 🐛 Bug fixes - Bad parameter type in `toggleCancelButton` search bar command by [@​kkafar](https://togithub.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1854](https://togithub.com/software-mansion/react-native-screens/pull/1854) - Add missing iOS API availbility checks by [@​kkafar](https://togithub.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1860](https://togithub.com/software-mansion/react-native-screens/pull/1860) #### 🔢 Miscellaneous - Update RN + other deps in example apps by [@​kkafar](https://togithub.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1847](https://togithub.com/software-mansion/react-native-screens/pull/1847) - Annotate `sheetExpandsWhenScrollingToEdge` prop as iOS specific by [@​kkafar](https://togithub.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1851](https://togithub.com/software-mansion/react-native-screens/pull/1851) - Improve readability of C++ namespaced types by [@​kkafar](https://togithub.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1856](https://togithub.com/software-mansion/react-native-screens/pull/1856) **Full Changelog**: software-mansion/react-native-screens@3.23.0...3.24.0 ### [`v3.23.0`](https://togithub.com/software-mansion/react-native-screens/releases/tag/3.23.0) [Compare Source](https://togithub.com/software-mansion/react-native-screens/compare/3.22.1...3.23.0) #### What's Changed #### 🐛 Bug fixes - Headerheight incorrect on phones with dynamic island by [@​dylancom](https://togithub.com/dylancom) in [https://github.com/software-mansion/react-native-screens/pull/1784](https://togithub.com/software-mansion/react-native-screens/pull/1784) - Buggy search bar / large title behaviour on Fabric by [@​kkafar](https://togithub.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1825](https://togithub.com/software-mansion/react-native-screens/pull/1825) - Make RNSFullWindowOverlay a modal for accessibility by [@​kkafar](https://togithub.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1842](https://togithub.com/software-mansion/react-native-screens/pull/1842) - Calculate large headers in `useHeaderHeight` hook by [@​tboba](https://togithub.com/tboba) in [https://github.com/software-mansion/react-native-screens/pull/1844](https://togithub.com/software-mansion/react-native-screens/pull/1844) #### 👍 Improvements - Add onGestureCancel event by [@​piaskowyk](https://togithub.com/piaskowyk) in [https://github.com/software-mansion/react-native-screens/pull/1810](https://togithub.com/software-mansion/react-native-screens/pull/1810) - Add support for search bar placement by [@​kkafar](https://togithub.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1843](https://togithub.com/software-mansion/react-native-screens/pull/1843) #### 🔢 Miscellaneous - Update `tough-cookie` and `semver` dependencies by [@​tboba](https://togithub.com/tboba) in [https://github.com/software-mansion/react-native-screens/pull/1823](https://togithub.com/software-mansion/react-native-screens/pull/1823) - Bump versions of RNScreens, FBReactNativeSpec and RCTAppDelegate deps by [@​tboba](https://togithub.com/tboba) in [https://github.com/software-mansion/react-native-screens/pull/1827](https://togithub.com/software-mansion/react-native-screens/pull/1827) - Update `word-wrap` by [@​kkafar](https://togithub.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1834](https://togithub.com/software-mansion/react-native-screens/pull/1834) - Format code in test examples by [@​kkafar](https://togithub.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1812](https://togithub.com/software-mansion/react-native-screens/pull/1812) - Unify class & method naming with respect to conventions by [@​kkafar](https://togithub.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1841](https://togithub.com/software-mansion/react-native-screens/pull/1841) #### New Contributors - [@​piaskowyk](https://togithub.com/piaskowyk) made their first contribution in [https://github.com/software-mansion/react-native-screens/pull/1810](https://togithub.com/software-mansion/react-native-screens/pull/1810) - [@​tboba](https://togithub.com/tboba) made their first contribution in [https://github.com/software-mansion/react-native-screens/pull/1823](https://togithub.com/software-mansion/react-native-screens/pull/1823) **Full Changelog**: software-mansion/react-native-screens@3.22.1...3.23.0 ### [`v3.22.1`](https://togithub.com/software-mansion/react-native-screens/releases/tag/3.22.1) [Compare Source](https://togithub.com/software-mansion/react-native-screens/compare/3.22.0...3.22.1) Patch release bringing back old behaviour of `formSheet` modal on iOS when using `@react-navigation/native-stack`. #### What's Changed ##### Fixes - fix: move setting default values of medium-detent related props to `InnerScreen` by [@​kkafar](https://togithub.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1811](https://togithub.com/software-mansion/react-native-screens/pull/1811) ##### Internal - chore: fix CI by [@​kkafar](https://togithub.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1803](https://togithub.com/software-mansion/react-native-screens/pull/1803) - chore(deps): update selected deps in examples by [@​kkafar](https://togithub.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1807](https://togithub.com/software-mansion/react-native-screens/pull/1807) - chore: fix typo in docs by [@​aleqsio](https://togithub.com/aleqsio) in [https://github.com/software-mansion/react-native-screens/pull/1808](https://togithub.com/software-mansion/react-native-screens/pull/1808) #### New Contributors - [@​aleqsio](https://togithub.com/aleqsio) made their first contribution in [https://github.com/software-mansion/react-native-screens/pull/1808](https://togithub.com/software-mansion/react-native-screens/pull/1808) **Full Changelog**: software-mansion/react-native-screens@3.22.0...3.22.1 ### [`v3.22.0`](https://togithub.com/software-mansion/react-native-screens/releases/tag/3.22.0) [Compare Source](https://togithub.com/software-mansion/react-native-screens/compare/3.21.1...3.22.0) Minor release fixing some build issues that could happen on older Xcode versions & with Android SDK 34. #### What's Changed - fix: canvas nullability in ScreenStack for Android SDK 34 by [@​kkafar](https://togithub.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1795](https://togithub.com/software-mansion/react-native-screens/pull/1795) - fix: ifdef orientation code that requries iOS 16 by [@​kkafar](https://togithub.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1794](https://togithub.com/software-mansion/react-native-screens/pull/1794) - chore: update & reinstall selected deps by [@​kkafar](https://togithub.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1798](https://togithub.com/software-mansion/react-native-screens/pull/1798) **Full Changelog**: software-mansion/react-native-screens@3.21.1...3.22.0 ### [`v3.21.1`](https://togithub.com/software-mansion/react-native-screens/releases/tag/3.21.1) [Compare Source](https://togithub.com/software-mansion/react-native-screens/compare/3.21.0...3.21.1) Patch release adding internal `isNewBackTitleImplementation` constant for use in `@react-navigation/native-stack`. See [#​1791](https://togithub.com/software-mansion/react-native-screens/issues/1791) & [https://github.com/react-navigation/react-navigation/pull/11423](https://togithub.com/react-navigation/react-navigation/pull/11423) for details. ### [`v3.21.0`](https://togithub.com/software-mansion/react-native-screens/releases/tag/3.21.0) [Compare Source](https://togithub.com/software-mansion/react-native-screens/compare/3.20.0...3.21.0) Minor release with support for React Native 0.72 on New Architecture, fixing some bugs and adding new functionalities. Please note that support for `react-navigation` v4 has been dropped with this version and you can no longer use `native-stack` v4 starting from this version. It might be considered a **BREAKING CHANGE** so be careful with updating. #### What's Changed - chore: migrate codegen to TypeScript by [@​kkafar](https://togithub.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1600](https://togithub.com/software-mansion/react-native-screens/pull/1600) - chore: update README on Fabric support by [@​kkafar](https://togithub.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1687](https://togithub.com/software-mansion/react-native-screens/pull/1687) - feat(iOS): back button subview for Fabric by [@​kkafar](https://togithub.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1581](https://togithub.com/software-mansion/react-native-screens/pull/1581) - fix(iOS): image loading for back button on Fabric by [@​kkafar](https://togithub.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1688](https://togithub.com/software-mansion/react-native-screens/pull/1688) - chore: refactor medium detent iOS implementation by [@​kkafar](https://togithub.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1699](https://togithub.com/software-mansion/react-native-screens/pull/1699) - feat(Android): add native default animations on Android 13 by [@​kkafar](https://togithub.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1693](https://togithub.com/software-mansion/react-native-screens/pull/1693) - chore: fix e2e detox tests & `Example` by [@​kkafar](https://togithub.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1681](https://togithub.com/software-mansion/react-native-screens/pull/1681) - fix(iOS): status bar does not respect app theme by [@​kkafar](https://togithub.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1708](https://togithub.com/software-mansion/react-native-screens/pull/1708) - chore(deps): bump http-cache-semantics from 4.1.0 to 4.1.1 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/software-mansion/react-native-screens/pull/1709](https://togithub.com/software-mansion/react-native-screens/pull/1709) - chore: change fabric flag by [@​WoLewicki](https://togithub.com/WoLewicki) in [https://github.com/software-mansion/react-native-screens/pull/1705](https://togithub.com/software-mansion/react-native-screens/pull/1705) - chore(CI): extend timeout for Android e2e by [@​kkafar](https://togithub.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1711](https://togithub.com/software-mansion/react-native-screens/pull/1711) - chore: update deps in examples by [@​kkafar](https://togithub.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1714](https://togithub.com/software-mansion/react-native-screens/pull/1714) - chore: update library & examples dependencies by [@​kkafar](https://togithub.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1721](https://togithub.com/software-mansion/react-native-screens/pull/1721) - fix: Android build for `compileSdk < 33` by [@​kkafar](https://togithub.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1723](https://togithub.com/software-mansion/react-native-screens/pull/1723) - feat: add imperative API for search bar by [@​kkafar](https://togithub.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1610](https://togithub.com/software-mansion/react-native-screens/pull/1610) - chore(deps): bump shell-quote from 1.6.1 to 1.8.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/software-mansion/react-native-screens/pull/1725](https://togithub.com/software-mansion/react-native-screens/pull/1725) - chore: improve Android anim resource management by [@​kkafar](https://togithub.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1727](https://togithub.com/software-mansion/react-native-screens/pull/1727) - chore: fix typo in build script by [@​Jace-Samsung](https://togithub.com/Jace-Samsung) in [https://github.com/software-mansion/react-native-screens/pull/1733](https://togithub.com/software-mansion/react-native-screens/pull/1733) - chore: set library namespace in build script by [@​Sprimage](https://togithub.com/Sprimage) in [https://github.com/software-mansion/react-native-screens/pull/1717](https://togithub.com/software-mansion/react-native-screens/pull/1717) - fix(iOS): back button not respecting style options by [@​tyler-coleman](https://togithub.com/tyler-coleman) in [https://github.com/software-mansion/react-native-screens/pull/1726](https://togithub.com/software-mansion/react-native-screens/pull/1726) - chore: override `onCreate` in example apps by [@​kkafar](https://togithub.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1736](https://togithub.com/software-mansion/react-native-screens/pull/1736) - feat: add `setText` command on SearchBar by [@​kkafar](https://togithub.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1739](https://togithub.com/software-mansion/react-native-screens/pull/1739) - chore(deps): bump activesupport from 6.1.4.6 to 7.0.4.3 by [@​kkafar](https://togithub.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1744](https://togithub.com/software-mansion/react-native-screens/pull/1744) - fix: do not apply namespace if it is not available in agp by [@​WoLewicki](https://togithub.com/WoLewicki) in [https://github.com/software-mansion/react-native-screens/pull/1749](https://togithub.com/software-mansion/react-native-screens/pull/1749) - chore(deps): bump vm2 from 3.9.14 to 3.9.15 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/software-mansion/react-native-screens/pull/1752](https://togithub.com/software-mansion/react-native-screens/pull/1752) - fix: use new rotation API for iOS 16 by [@​kirillzyusko](https://togithub.com/kirillzyusko) in [https://github.com/software-mansion/react-native-screens/pull/1732](https://togithub.com/software-mansion/react-native-screens/pull/1732) - chore: improve Android 13 animations by [@​kkafar](https://togithub.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1756](https://togithub.com/software-mansion/react-native-screens/pull/1756) - chore(deps): bump vm2 from 3.9.15 to 3.9.16 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/software-mansion/react-native-screens/pull/1755](https://togithub.com/software-mansion/react-native-screens/pull/1755) - fix: ScreenStackHeaderConfig type by [@​tomekzaw](https://togithub.com/tomekzaw) in [https://github.com/software-mansion/react-native-screens/pull/1760](https://togithub.com/software-mansion/react-native-screens/pull/1760) - feat: remove v4 from repo by [@​WoLewicki](https://togithub.com/WoLewicki) in [https://github.com/software-mansion/react-native-screens/pull/1790](https://togithub.com/software-mansion/react-native-screens/pull/1790) - fix:Compatible with version 0.72 by [@​NiuGuohui](https://togithub.com/NiuGuohui) in [https://github.com/software-mansion/react-native-screens/pull/1765](https://togithub.com/software-mansion/react-native-screens/pull/1765) - fix: proper handling of header events on Fabric and bumping examples to 0.72 by [@​WoLewicki](https://togithub.com/WoLewicki) in [https://github.com/software-mansion/react-native-screens/pull/1783](https://togithub.com/software-mansion/react-native-screens/pull/1783) - feat: prevent native back button dismissal on iOS by [@​WoLewicki](https://togithub.com/WoLewicki) in [https://github.com/software-mansion/react-native-screens/pull/1773](https://togithub.com/software-mansion/react-native-screens/pull/1773) #### New Contributors - [@​Jace-Samsung](https://togithub.com/Jace-Samsung) made their first contribution in [https://github.com/software-mansion/react-native-screens/pull/1733](https://togithub.com/software-mansion/react-native-screens/pull/1733) - [@​Sprimage](https://togithub.com/Sprimage) made their first contribution in [https://github.com/software-mansion/react-native-screens/pull/1717](https://togithub.com/software-mansion/react-native-screens/pull/1717) - [@​tyler-coleman](https://togithub.com/tyler-coleman) made their first contribution in [https://github.com/software-mansion/react-native-screens/pull/1726](https://togithub.com/software-mansion/react-native-screens/pull/1726) - [@​NiuGuohui](https://togithub.com/NiuGuohui) made their first contribution in [https://github.com/software-mansion/react-native-screens/pull/1765](https://togithub.com/software-mansion/react-native-screens/pull/1765) **Full Changelog**: software-mansion/react-native-screens@3.20.0...3.21.0 ### [`v3.20.0`](https://togithub.com/software-mansion/react-native-screens/releases/tag/3.20.0) [Compare Source](https://togithub.com/software-mansion/react-native-screens/compare/3.19.0...3.20.0) Minior release aimed at fixing [#​1686](https://togithub.com/software-mansion/react-native-screens/issues/1686) (change of default behaviour for `stackPresentation: 'formSheet'`). No other changes were introduced with this release. Next "feature" release is in preparation. **Full Changelog**: software-mansion/react-native-screens@3.19.0...3.20.0 ### [`v3.19.0`](https://togithub.com/software-mansion/react-native-screens/releases/tag/3.19.0) [Compare Source](https://togithub.com/software-mansion/react-native-screens/compare/3.18.2...3.19.0) Minor release with support for React Native 0.71 **Important**: Since this version, Fabric is only supported for React Native 0.71+. Support for older versions has beed dropped. #### 🐛 Bug fixes - Try to apply pointer events behaviors in overlay by [@​WoLewicki](https://togithub.com/WoLewicki) in [https://github.com/software-mansion/react-native-screens/pull/1582](https://togithub.com/software-mansion/react-native-screens/pull/1582) - Make enabling device orientation notifications internal by [@​kacperkapusciak](https://togithub.com/kacperkapusciak) & [@​kkafar](https://togithub.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1596](https://togithub.com/software-mansion/react-native-screens/pull/1596) - Fix back button menu for headerBackTitleVisible prop by [@​kacperkapusciak](https://togithub.com/kacperkapusciak) in [https://github.com/software-mansion/react-native-screens/pull/1646](https://togithub.com/software-mansion/react-native-screens/pull/1646) - Override requiresMainQueueSetup in RNSScreenManager by [@​kkafar](https://togithub.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1670](https://togithub.com/software-mansion/react-native-screens/pull/1670) #### 👍 Improvements - Support for React Native 0.71.0 by [@​kkafar](https://togithub.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1631](https://togithub.com/software-mansion/react-native-screens/pull/1631) - Clarify installation instructions for Android by [@​evan1715](https://togithub.com/evan1715) in [https://github.com/software-mansion/react-native-screens/pull/1633](https://togithub.com/software-mansion/react-native-screens/pull/1633) #### 🔢 Miscellaneous - Fix FabricTestExample fails to start due to new `react-native.config.js` by [@​kkafar](https://togithub.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1624](https://togithub.com/software-mansion/react-native-screens/pull/1624) - Examples stopped to work after RN issue by [@​kkafar](https://togithub.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1632](https://togithub.com/software-mansion/react-native-screens/pull/1632) - Exclude android/.settings file form repo by [@​kkafar](https://togithub.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1642](https://togithub.com/software-mansion/react-native-screens/pull/1642) - Bump deps & fix tvOS build by [@​kkafar](https://togithub.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1667](https://togithub.com/software-mansion/react-native-screens/pull/1667) - Unify CI between platforms by [@​kkafar](https://togithub.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1676](https://togithub.com/software-mansion/react-native-screens/pull/1676) #### New Contributors - [@​evan1715](https://togithub.com/evan1715) made their first contribution in [https://github.com/software-mansion/react-native-screens/pull/1633](https://togithub.com/software-mansion/react-native-screens/pull/1633) **Full Changelog**: software-mansion/react-native-screens@3.18.2...3.19.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone America/Los_Angeles. 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/valora-inc/wallet). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xOS4yIiwidXBkYXRlZEluVmVyIjoiMzcuMTkuMiIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: valora-bot <valorabot@valoraapp.com>
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [react-native-screens](https://togithub.com/software-mansion/react-native-screens) | [`^3.18.2` -> `^3.25.0`](https://renovatebot.com/diffs/npm/react-native-screens/3.18.2/3.25.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/react-native-screens/3.25.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/react-native-screens/3.25.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/react-native-screens/3.18.2/3.25.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/react-native-screens/3.18.2/3.25.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>software-mansion/react-native-screens (react-native-screens)</summary> ### [`v3.25.0`](https://togithub.com/software-mansion/react-native-screens/releases/tag/3.25.0) [Compare Source](https://togithub.com/software-mansion/react-native-screens/compare/3.24.0...3.25.0) #### What's Changed Minor release focused on bug fixes & internals. #### 🐛 Bug fixes - iOS: Add missing call to super method in `RNSScreenView#finalizeUpdates` by [@​kkafar](https://togithub.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1855](https://togithub.com/software-mansion/react-native-screens/pull/1855) - Android: Shorten alpha animation to 83ms on default enter-out by [@​kkafar](https://togithub.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1835](https://togithub.com/software-mansion/react-native-screens/pull/1835) - iOS: Wrong title in back button menu for screens w/ hidden header by [@​kkafar](https://togithub.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1866](https://togithub.com/software-mansion/react-native-screens/pull/1866) - iOS: Full window overlay cannot receive tap when modal is full screen by [@​intergalacticspacehighway](https://togithub.com/intergalacticspacehighway) in [https://github.com/software-mansion/react-native-screens/pull/1872](https://togithub.com/software-mansion/react-native-screens/pull/1872) #### 🔢 Miscellaneous - Reinstall deps & pods in example apps after release by [@​kkafar](https://togithub.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1862](https://togithub.com/software-mansion/react-native-screens/pull/1862) - Fix typo in docs on `sheetCornerRadius` by [@​kkafar](https://togithub.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1863](https://togithub.com/software-mansion/react-native-screens/pull/1863) - Use `PlatformColor` instead of plain `string` for color related props by [@​retyui](https://togithub.com/retyui) in [https://github.com/software-mansion/react-native-screens/pull/1846](https://togithub.com/software-mansion/react-native-screens/pull/1846) - Android: Migrate `replaceSystemWindowInsets` to `Builder.setSystemWindowInsets` by [@​kirillzyusko](https://togithub.com/kirillzyusko) in [https://github.com/software-mansion/react-native-screens/pull/1868](https://togithub.com/software-mansion/react-native-screens/pull/1868) #### New Contributors - [@​intergalacticspacehighway](https://togithub.com/intergalacticspacehighway) made their first contribution in [https://github.com/software-mansion/react-native-screens/pull/1872](https://togithub.com/software-mansion/react-native-screens/pull/1872) - [@​retyui](https://togithub.com/retyui) made their first contribution in [https://github.com/software-mansion/react-native-screens/pull/1846](https://togithub.com/software-mansion/react-native-screens/pull/1846) **Full Changelog**: software-mansion/react-native-screens@3.24.0...3.25.0 ### [`v3.24.0`](https://togithub.com/software-mansion/react-native-screens/releases/tag/3.24.0) [Compare Source](https://togithub.com/software-mansion/react-native-screens/compare/3.23.0...3.24.0) Minor release focused on fixing build issues reported in [#​1859](https://togithub.com/software-mansion/react-native-screens/issues/1859). #### What's Changed #### 🐛 Bug fixes - Bad parameter type in `toggleCancelButton` search bar command by [@​kkafar](https://togithub.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1854](https://togithub.com/software-mansion/react-native-screens/pull/1854) - Add missing iOS API availbility checks by [@​kkafar](https://togithub.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1860](https://togithub.com/software-mansion/react-native-screens/pull/1860) #### 🔢 Miscellaneous - Update RN + other deps in example apps by [@​kkafar](https://togithub.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1847](https://togithub.com/software-mansion/react-native-screens/pull/1847) - Annotate `sheetExpandsWhenScrollingToEdge` prop as iOS specific by [@​kkafar](https://togithub.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1851](https://togithub.com/software-mansion/react-native-screens/pull/1851) - Improve readability of C++ namespaced types by [@​kkafar](https://togithub.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1856](https://togithub.com/software-mansion/react-native-screens/pull/1856) **Full Changelog**: software-mansion/react-native-screens@3.23.0...3.24.0 ### [`v3.23.0`](https://togithub.com/software-mansion/react-native-screens/releases/tag/3.23.0) [Compare Source](https://togithub.com/software-mansion/react-native-screens/compare/3.22.1...3.23.0) #### What's Changed #### 🐛 Bug fixes - Headerheight incorrect on phones with dynamic island by [@​dylancom](https://togithub.com/dylancom) in [https://github.com/software-mansion/react-native-screens/pull/1784](https://togithub.com/software-mansion/react-native-screens/pull/1784) - Buggy search bar / large title behaviour on Fabric by [@​kkafar](https://togithub.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1825](https://togithub.com/software-mansion/react-native-screens/pull/1825) - Make RNSFullWindowOverlay a modal for accessibility by [@​kkafar](https://togithub.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1842](https://togithub.com/software-mansion/react-native-screens/pull/1842) - Calculate large headers in `useHeaderHeight` hook by [@​tboba](https://togithub.com/tboba) in [https://github.com/software-mansion/react-native-screens/pull/1844](https://togithub.com/software-mansion/react-native-screens/pull/1844) #### 👍 Improvements - Add onGestureCancel event by [@​piaskowyk](https://togithub.com/piaskowyk) in [https://github.com/software-mansion/react-native-screens/pull/1810](https://togithub.com/software-mansion/react-native-screens/pull/1810) - Add support for search bar placement by [@​kkafar](https://togithub.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1843](https://togithub.com/software-mansion/react-native-screens/pull/1843) #### 🔢 Miscellaneous - Update `tough-cookie` and `semver` dependencies by [@​tboba](https://togithub.com/tboba) in [https://github.com/software-mansion/react-native-screens/pull/1823](https://togithub.com/software-mansion/react-native-screens/pull/1823) - Bump versions of RNScreens, FBReactNativeSpec and RCTAppDelegate deps by [@​tboba](https://togithub.com/tboba) in [https://github.com/software-mansion/react-native-screens/pull/1827](https://togithub.com/software-mansion/react-native-screens/pull/1827) - Update `word-wrap` by [@​kkafar](https://togithub.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1834](https://togithub.com/software-mansion/react-native-screens/pull/1834) - Format code in test examples by [@​kkafar](https://togithub.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1812](https://togithub.com/software-mansion/react-native-screens/pull/1812) - Unify class & method naming with respect to conventions by [@​kkafar](https://togithub.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1841](https://togithub.com/software-mansion/react-native-screens/pull/1841) #### New Contributors - [@​piaskowyk](https://togithub.com/piaskowyk) made their first contribution in [https://github.com/software-mansion/react-native-screens/pull/1810](https://togithub.com/software-mansion/react-native-screens/pull/1810) - [@​tboba](https://togithub.com/tboba) made their first contribution in [https://github.com/software-mansion/react-native-screens/pull/1823](https://togithub.com/software-mansion/react-native-screens/pull/1823) **Full Changelog**: software-mansion/react-native-screens@3.22.1...3.23.0 ### [`v3.22.1`](https://togithub.com/software-mansion/react-native-screens/releases/tag/3.22.1) [Compare Source](https://togithub.com/software-mansion/react-native-screens/compare/3.22.0...3.22.1) Patch release bringing back old behaviour of `formSheet` modal on iOS when using `@react-navigation/native-stack`. #### What's Changed ##### Fixes - fix: move setting default values of medium-detent related props to `InnerScreen` by [@​kkafar](https://togithub.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1811](https://togithub.com/software-mansion/react-native-screens/pull/1811) ##### Internal - chore: fix CI by [@​kkafar](https://togithub.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1803](https://togithub.com/software-mansion/react-native-screens/pull/1803) - chore(deps): update selected deps in examples by [@​kkafar](https://togithub.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1807](https://togithub.com/software-mansion/react-native-screens/pull/1807) - chore: fix typo in docs by [@​aleqsio](https://togithub.com/aleqsio) in [https://github.com/software-mansion/react-native-screens/pull/1808](https://togithub.com/software-mansion/react-native-screens/pull/1808) #### New Contributors - [@​aleqsio](https://togithub.com/aleqsio) made their first contribution in [https://github.com/software-mansion/react-native-screens/pull/1808](https://togithub.com/software-mansion/react-native-screens/pull/1808) **Full Changelog**: software-mansion/react-native-screens@3.22.0...3.22.1 ### [`v3.22.0`](https://togithub.com/software-mansion/react-native-screens/releases/tag/3.22.0) [Compare Source](https://togithub.com/software-mansion/react-native-screens/compare/3.21.1...3.22.0) Minor release fixing some build issues that could happen on older Xcode versions & with Android SDK 34. #### What's Changed - fix: canvas nullability in ScreenStack for Android SDK 34 by [@​kkafar](https://togithub.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1795](https://togithub.com/software-mansion/react-native-screens/pull/1795) - fix: ifdef orientation code that requries iOS 16 by [@​kkafar](https://togithub.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1794](https://togithub.com/software-mansion/react-native-screens/pull/1794) - chore: update & reinstall selected deps by [@​kkafar](https://togithub.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1798](https://togithub.com/software-mansion/react-native-screens/pull/1798) **Full Changelog**: software-mansion/react-native-screens@3.21.1...3.22.0 ### [`v3.21.1`](https://togithub.com/software-mansion/react-native-screens/releases/tag/3.21.1) [Compare Source](https://togithub.com/software-mansion/react-native-screens/compare/3.21.0...3.21.1) Patch release adding internal `isNewBackTitleImplementation` constant for use in `@react-navigation/native-stack`. See [#​1791](https://togithub.com/software-mansion/react-native-screens/issues/1791) & [https://github.com/react-navigation/react-navigation/pull/11423](https://togithub.com/react-navigation/react-navigation/pull/11423) for details. ### [`v3.21.0`](https://togithub.com/software-mansion/react-native-screens/releases/tag/3.21.0) [Compare Source](https://togithub.com/software-mansion/react-native-screens/compare/3.20.0...3.21.0) Minor release with support for React Native 0.72 on New Architecture, fixing some bugs and adding new functionalities. Please note that support for `react-navigation` v4 has been dropped with this version and you can no longer use `native-stack` v4 starting from this version. It might be considered a **BREAKING CHANGE** so be careful with updating. #### What's Changed - chore: migrate codegen to TypeScript by [@​kkafar](https://togithub.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1600](https://togithub.com/software-mansion/react-native-screens/pull/1600) - chore: update README on Fabric support by [@​kkafar](https://togithub.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1687](https://togithub.com/software-mansion/react-native-screens/pull/1687) - feat(iOS): back button subview for Fabric by [@​kkafar](https://togithub.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1581](https://togithub.com/software-mansion/react-native-screens/pull/1581) - fix(iOS): image loading for back button on Fabric by [@​kkafar](https://togithub.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1688](https://togithub.com/software-mansion/react-native-screens/pull/1688) - chore: refactor medium detent iOS implementation by [@​kkafar](https://togithub.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1699](https://togithub.com/software-mansion/react-native-screens/pull/1699) - feat(Android): add native default animations on Android 13 by [@​kkafar](https://togithub.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1693](https://togithub.com/software-mansion/react-native-screens/pull/1693) - chore: fix e2e detox tests & `Example` by [@​kkafar](https://togithub.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1681](https://togithub.com/software-mansion/react-native-screens/pull/1681) - fix(iOS): status bar does not respect app theme by [@​kkafar](https://togithub.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1708](https://togithub.com/software-mansion/react-native-screens/pull/1708) - chore(deps): bump http-cache-semantics from 4.1.0 to 4.1.1 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/software-mansion/react-native-screens/pull/1709](https://togithub.com/software-mansion/react-native-screens/pull/1709) - chore: change fabric flag by [@​WoLewicki](https://togithub.com/WoLewicki) in [https://github.com/software-mansion/react-native-screens/pull/1705](https://togithub.com/software-mansion/react-native-screens/pull/1705) - chore(CI): extend timeout for Android e2e by [@​kkafar](https://togithub.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1711](https://togithub.com/software-mansion/react-native-screens/pull/1711) - chore: update deps in examples by [@​kkafar](https://togithub.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1714](https://togithub.com/software-mansion/react-native-screens/pull/1714) - chore: update library & examples dependencies by [@​kkafar](https://togithub.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1721](https://togithub.com/software-mansion/react-native-screens/pull/1721) - fix: Android build for `compileSdk < 33` by [@​kkafar](https://togithub.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1723](https://togithub.com/software-mansion/react-native-screens/pull/1723) - feat: add imperative API for search bar by [@​kkafar](https://togithub.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1610](https://togithub.com/software-mansion/react-native-screens/pull/1610) - chore(deps): bump shell-quote from 1.6.1 to 1.8.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/software-mansion/react-native-screens/pull/1725](https://togithub.com/software-mansion/react-native-screens/pull/1725) - chore: improve Android anim resource management by [@​kkafar](https://togithub.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1727](https://togithub.com/software-mansion/react-native-screens/pull/1727) - chore: fix typo in build script by [@​Jace-Samsung](https://togithub.com/Jace-Samsung) in [https://github.com/software-mansion/react-native-screens/pull/1733](https://togithub.com/software-mansion/react-native-screens/pull/1733) - chore: set library namespace in build script by [@​Sprimage](https://togithub.com/Sprimage) in [https://github.com/software-mansion/react-native-screens/pull/1717](https://togithub.com/software-mansion/react-native-screens/pull/1717) - fix(iOS): back button not respecting style options by [@​tyler-coleman](https://togithub.com/tyler-coleman) in [https://github.com/software-mansion/react-native-screens/pull/1726](https://togithub.com/software-mansion/react-native-screens/pull/1726) - chore: override `onCreate` in example apps by [@​kkafar](https://togithub.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1736](https://togithub.com/software-mansion/react-native-screens/pull/1736) - feat: add `setText` command on SearchBar by [@​kkafar](https://togithub.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1739](https://togithub.com/software-mansion/react-native-screens/pull/1739) - chore(deps): bump activesupport from 6.1.4.6 to 7.0.4.3 by [@​kkafar](https://togithub.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1744](https://togithub.com/software-mansion/react-native-screens/pull/1744) - fix: do not apply namespace if it is not available in agp by [@​WoLewicki](https://togithub.com/WoLewicki) in [https://github.com/software-mansion/react-native-screens/pull/1749](https://togithub.com/software-mansion/react-native-screens/pull/1749) - chore(deps): bump vm2 from 3.9.14 to 3.9.15 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/software-mansion/react-native-screens/pull/1752](https://togithub.com/software-mansion/react-native-screens/pull/1752) - fix: use new rotation API for iOS 16 by [@​kirillzyusko](https://togithub.com/kirillzyusko) in [https://github.com/software-mansion/react-native-screens/pull/1732](https://togithub.com/software-mansion/react-native-screens/pull/1732) - chore: improve Android 13 animations by [@​kkafar](https://togithub.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1756](https://togithub.com/software-mansion/react-native-screens/pull/1756) - chore(deps): bump vm2 from 3.9.15 to 3.9.16 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/software-mansion/react-native-screens/pull/1755](https://togithub.com/software-mansion/react-native-screens/pull/1755) - fix: ScreenStackHeaderConfig type by [@​tomekzaw](https://togithub.com/tomekzaw) in [https://github.com/software-mansion/react-native-screens/pull/1760](https://togithub.com/software-mansion/react-native-screens/pull/1760) - feat: remove v4 from repo by [@​WoLewicki](https://togithub.com/WoLewicki) in [https://github.com/software-mansion/react-native-screens/pull/1790](https://togithub.com/software-mansion/react-native-screens/pull/1790) - fix:Compatible with version 0.72 by [@​NiuGuohui](https://togithub.com/NiuGuohui) in [https://github.com/software-mansion/react-native-screens/pull/1765](https://togithub.com/software-mansion/react-native-screens/pull/1765) - fix: proper handling of header events on Fabric and bumping examples to 0.72 by [@​WoLewicki](https://togithub.com/WoLewicki) in [https://github.com/software-mansion/react-native-screens/pull/1783](https://togithub.com/software-mansion/react-native-screens/pull/1783) - feat: prevent native back button dismissal on iOS by [@​WoLewicki](https://togithub.com/WoLewicki) in [https://github.com/software-mansion/react-native-screens/pull/1773](https://togithub.com/software-mansion/react-native-screens/pull/1773) #### New Contributors - [@​Jace-Samsung](https://togithub.com/Jace-Samsung) made their first contribution in [https://github.com/software-mansion/react-native-screens/pull/1733](https://togithub.com/software-mansion/react-native-screens/pull/1733) - [@​Sprimage](https://togithub.com/Sprimage) made their first contribution in [https://github.com/software-mansion/react-native-screens/pull/1717](https://togithub.com/software-mansion/react-native-screens/pull/1717) - [@​tyler-coleman](https://togithub.com/tyler-coleman) made their first contribution in [https://github.com/software-mansion/react-native-screens/pull/1726](https://togithub.com/software-mansion/react-native-screens/pull/1726) - [@​NiuGuohui](https://togithub.com/NiuGuohui) made their first contribution in [https://github.com/software-mansion/react-native-screens/pull/1765](https://togithub.com/software-mansion/react-native-screens/pull/1765) **Full Changelog**: software-mansion/react-native-screens@3.20.0...3.21.0 ### [`v3.20.0`](https://togithub.com/software-mansion/react-native-screens/releases/tag/3.20.0) [Compare Source](https://togithub.com/software-mansion/react-native-screens/compare/3.19.0...3.20.0) Minior release aimed at fixing [#​1686](https://togithub.com/software-mansion/react-native-screens/issues/1686) (change of default behaviour for `stackPresentation: 'formSheet'`). No other changes were introduced with this release. Next "feature" release is in preparation. **Full Changelog**: software-mansion/react-native-screens@3.19.0...3.20.0 ### [`v3.19.0`](https://togithub.com/software-mansion/react-native-screens/releases/tag/3.19.0) [Compare Source](https://togithub.com/software-mansion/react-native-screens/compare/3.18.2...3.19.0) Minor release with support for React Native 0.71 **Important**: Since this version, Fabric is only supported for React Native 0.71+. Support for older versions has beed dropped. #### 🐛 Bug fixes - Try to apply pointer events behaviors in overlay by [@​WoLewicki](https://togithub.com/WoLewicki) in [https://github.com/software-mansion/react-native-screens/pull/1582](https://togithub.com/software-mansion/react-native-screens/pull/1582) - Make enabling device orientation notifications internal by [@​kacperkapusciak](https://togithub.com/kacperkapusciak) & [@​kkafar](https://togithub.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1596](https://togithub.com/software-mansion/react-native-screens/pull/1596) - Fix back button menu for headerBackTitleVisible prop by [@​kacperkapusciak](https://togithub.com/kacperkapusciak) in [https://github.com/software-mansion/react-native-screens/pull/1646](https://togithub.com/software-mansion/react-native-screens/pull/1646) - Override requiresMainQueueSetup in RNSScreenManager by [@​kkafar](https://togithub.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1670](https://togithub.com/software-mansion/react-native-screens/pull/1670) #### 👍 Improvements - Support for React Native 0.71.0 by [@​kkafar](https://togithub.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1631](https://togithub.com/software-mansion/react-native-screens/pull/1631) - Clarify installation instructions for Android by [@​evan1715](https://togithub.com/evan1715) in [https://github.com/software-mansion/react-native-screens/pull/1633](https://togithub.com/software-mansion/react-native-screens/pull/1633) #### 🔢 Miscellaneous - Fix FabricTestExample fails to start due to new `react-native.config.js` by [@​kkafar](https://togithub.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1624](https://togithub.com/software-mansion/react-native-screens/pull/1624) - Examples stopped to work after RN issue by [@​kkafar](https://togithub.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1632](https://togithub.com/software-mansion/react-native-screens/pull/1632) - Exclude android/.settings file form repo by [@​kkafar](https://togithub.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1642](https://togithub.com/software-mansion/react-native-screens/pull/1642) - Bump deps & fix tvOS build by [@​kkafar](https://togithub.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1667](https://togithub.com/software-mansion/react-native-screens/pull/1667) - Unify CI between platforms by [@​kkafar](https://togithub.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1676](https://togithub.com/software-mansion/react-native-screens/pull/1676) #### New Contributors - [@​evan1715](https://togithub.com/evan1715) made their first contribution in [https://github.com/software-mansion/react-native-screens/pull/1633](https://togithub.com/software-mansion/react-native-screens/pull/1633) **Full Changelog**: software-mansion/react-native-screens@3.18.2...3.19.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone America/Los_Angeles. 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/valora-inc/wallet). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xOS4yIiwidXBkYXRlZEluVmVyIjoiMzcuMTkuMiIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: valora-bot <valorabot@valoraapp.com>
Description
UIKit documentation states that in order to successfully use orientation in iOS apps the orientation has to be enabled via the
beginGeneratingDeviceOrientationNotifications
method. This was addressed in #1543.This PR attempts to make this change internal and also removing an additional
react-native-screens
installation step from README.PR made based on code from
expo-screen-orientation
package from this line.Fixes react-navigation/react-navigation.github.io#1177
Note by @kkafar:
For now I went with placing the code in ctor/dtor of
RNSScreen
view manager.The view manager construction & lifecycle is managed by React Native's internals (and is executed during application startup). This behaviour is considered stable (changing this would be braking change for RN Paper architecture).
I considered also:
dispatch_once
in+ (voi)enforceDesiredDeviceOrientation
method - and calling only thebegin...
method (as there would be no place to call the respondingend...
method.begin...
/end...
methods every timeenforceDesiredDeviceOrientation
is being called.RNSScreenWindowTraits
and creating a static object. But I had objections. I feared that compiler might optimise-out (remove) this static variable since it is unused. I've found some mails form gcc-help mailing list indicating that it might be the case.Changes
beginGeneratingDeviceOrientationNotifications
andendGeneratingDeviceOrientationNotifications
methods from applicationsAppDelegate
s toRNSScreenManager
init
/dealloc
methods.Testing
I attached a breakpoint to see that added code ends actually being called.
Orientation playground in
Example/
app.Checklist