fix: fast ios modal push #1326
Merged
fix: fast ios modal push #1326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
kacperkapusciak
approved these changes
Feb 28, 2022
6 tasks
kkafar
added a commit
that referenced
this pull request
Feb 6, 2025
…s being dismissed (#2671) ## Description Closes #2668 See the #2668 for issue description. Making long story short: The issue involves cases when we have two modals `A, b`, where `A` is owned and `b` is foreign, and we dismiss `b` and present another owned modal `B` in single transaction or in separate transactions but pulled quickly enough so that previous transitions (caused by previous transaction) are not finished yet. Currently, because of `b` being dismissed by its host view controller, we would wrongfully dismiss the controller underneath (`A`). Now the code takes possibility of `b` being in dismissal into account. ## Changes We now check whether the potentially foreign modal is being dismissed - if so, we schedule our updates to run **after** dismissal transition completes. ## Test code and steps to reproduce Tested for regressions: * [x] `Modal` screen in Example [PR](#1996) * [x] Test2048 [PR](#2113) * [x] Test1829 [PR](#1912) * [x] Test1299 [PR](#1326) This issue is quite similar to #1299 but concerns foreign modal not owned one and mechanism are a bit different, therefore I've added `Test2668`. ## Checklist - [x] Included code example that can be used to test this change - [x] Ensured that CI passes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix bug with pushing modals on
iOStoo fast. See #1299 for more info. It would be nice to test if this new behavior does not introduce unwanted problems around pushing new screens after the dismissal of the modal.Fixes react-navigation/react-navigation#10324
Fixes #1299
Test code and steps to reproduce
Test1299.tsx.Checklist