Add warning when passing incorrect transformOrigin #6602
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Some view props, like colors are processed on JS level, so we process it in updateProps function:
react-native-reanimated/packages/react-native-reanimated/src/UpdateProps.ts
Line 34 in f03ab14
However we don't implement our copy of processTransformOrigin and passing transformOrigin in a form of string crashes the app with a confusing error "Exception in HostFunction: , js engine: reanimated"
Yet, if transformOrigin is provided as an array of 3 numbers (just as you would get after calling processTransformOrigin on it) everything works fine, so I've added a warning explaining the problem.
Note
Similarly a fontVariant in form of string passed in useAnimatedStyle will not work. However this is not going to crash the whole app, so we probably want to ignore it. Also fontVariant accepts quantified values, so it doesn't make as much sense to animate it.
Test plan
This crash: #5895 doesn't have misleading error message.