Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Remove 'worklets' dependency on NativeReanimatedModule #6357

Merged
merged 4 commits into from
Aug 8, 2024
Merged

refactor: Remove 'worklets' dependency on NativeReanimatedModule #6357

merged 4 commits into from
Aug 8, 2024

Conversation

tjzel
Copy link
Collaborator

@tjzel tjzel commented Jul 31, 2024 •
edited
Loading

Summary

Just applying some dependency inversion principle. Basically now RNRuntimeDecorator defines an interface that its callers have to conform to.

Keep in mind this isn't the final shape of how the code is split, I'm submitting this PR for granularity of the changes.

Test plan

  • Android builds & runs
    • on Paper
      • in Development
      • in Release
    • on Fabric
      • in Development
      • in Release
  • iOS builds & runs
    • on Paper
      • in Development
      • in Release
    • on Fabric
      • in Development
      • in Release

@tjzel tjzel force-pushed the @tjzel/worklets/remove-worklet-dependency branch from 68a6688 to de9b068 Compare August 1, 2024 13:23
@tjzel tjzel mentioned this pull request Aug 1, 2024
Merged
1 task
bartlomiejbloniarz
bartlomiejbloniarz approved these changes Aug 1, 2024
View reviewed changes
Copy link
Contributor

@bartlomiejbloniarz bartlomiejbloniarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🪨

tomekzaw
tomekzaw requested changes Aug 6, 2024
View reviewed changes
Copy link
Member

@tomekzaw tomekzaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes so that I can peacefully review this PR

tomekzaw
tomekzaw requested changes Aug 8, 2024
View reviewed changes
packages/react-native-reanimated/Common/cpp/reanimated/NativeModules/NativeReanimatedModule.cpp Outdated Show resolved Hide resolved
...act-native-reanimated/Common/cpp/reanimated/RuntimeDecorators/REAWorkletRuntimeDecorator.cpp Outdated Show resolved Hide resolved
...act-native-reanimated/Common/cpp/reanimated/RuntimeDecorators/REAWorkletRuntimeDecorator.cpp Outdated Show resolved Hide resolved
...act-native-reanimated/Common/cpp/reanimated/RuntimeDecorators/REAWorkletRuntimeDecorator.cpp Outdated Show resolved Hide resolved
packages/react-native-reanimated/apple/native/NativeProxy.mm Outdated Show resolved Hide resolved
packages/react-native-reanimated/Common/cpp/reanimated/RuntimeDecorators/RNRuntimeDecorator.cpp Show resolved Hide resolved
packages/react-native-reanimated/android/src/main/reanimated/CMakeLists.txt Show resolved Hide resolved
@tomekzaw tomekzaw changed the title refactor: Remove 'worklets' dependency on nativeReanimatedModule refactor: Remove 'worklets' dependency on NativeReanimatedModule Aug 8, 2024
@tjzel tjzel added this pull request to the merge queue Aug 8, 2024
Merged via the queue into main with commit 0d6db8d Aug 8, 2024
13 checks passed
@tjzel tjzel deleted the @tjzel/worklets/remove-worklet-dependency branch August 8, 2024 14:14
github-merge-queue bot pushed a commit that referenced this pull request Aug 12, 2024
@tjzel
refactor: Split Java and ObjC code into Reanimated and Worklets dirs (#…
2a8ff37 
…6366)

## Summary

This PR is the continuation of the code split made in common C++ layer.
All of the files currently go to `reanimated` directory, moving some of
them to `worklets` will happen in follow-up PRs.

Requires #6357.

## Test plan

- [ ] CI passes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomiejbloniarz bartlomiejbloniarz bartlomiejbloniarz approved these changes

@tomekzaw tomekzaw tomekzaw approved these changes

@piaskowyk piaskowyk Awaiting requested review from piaskowyk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tjzel @tomekzaw @bartlomiejbloniarz