Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: split makeMutable to web and native implementations #6307

Merged
merged 6 commits into from
Jul 22, 2024
Merged

refactor: split makeMutable to web and native implementations #6307

merged 6 commits into from
Jul 22, 2024

Conversation

tjzel
Copy link
Collaborator

@tjzel tjzel commented Jul 22, 2024 •
edited
Loading

Summary

Currently Web and Native implementations of makeMutable are bundled together and are hard to read. I split them for more clarity in the code, and also to prepare makeMutable for its further changes.

Test plan

  • Runtime tests pass.

tomekzaw
tomekzaw approved these changes Jul 22, 2024
View reviewed changes
Copy link
Member

@tomekzaw tomekzaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We could rename makeMutableUI to makeMutableNativeUI but the current name is fine as well.

@tjzel
Copy link
Collaborator Author

tjzel commented Jul 22, 2024

LGTM. We could rename makeMutableUI to makeMutableNativeUI but the current name is fine as well.

This would suggest that there would be makeMutableWebUI which isn't going to be the case soon.

@tjzel tjzel added this pull request to the merge queue Jul 22, 2024
Merged via the queue into main with commit a15e0ed Jul 22, 2024
6 checks passed
@tjzel tjzel deleted the @tjzel/split-make-mutable branch July 22, 2024 17:57
@chaitanyapotti chaitanyapotti mentioned this pull request Aug 28, 2024
Open
@phucle1010 phucle1010 mentioned this pull request Aug 28, 2024
Open
@arenault-pass arenault-pass mentioned this pull request Aug 28, 2024
Closed
@jaydenchee97 jaydenchee97 mentioned this pull request Aug 28, 2024
Open
@azu-josh azu-josh mentioned this pull request Aug 28, 2024
Open
@phucle1010 phucle1010 mentioned this pull request Aug 29, 2024
Open
@Bonnie-TJ Bonnie-TJ mentioned this pull request Sep 4, 2024
Merged
@tanyipeng834 tanyipeng834 mentioned this pull request Sep 4, 2024
Open
@arenault-pass arenault-pass mentioned this pull request Sep 6, 2024
Closed
@mhmoudmhmed mhmoudmhmed mentioned this pull request Sep 7, 2024
Open
This was referenced Sep 7, 2024
Closed
Closed
@phucle1010 phucle1010 mentioned this pull request Sep 24, 2024
Open
@arenault-pass arenault-pass mentioned this pull request Sep 24, 2024
Closed
@waveyboym waveyboym mentioned this pull request Sep 24, 2024
Open
@waveyboym waveyboym mentioned this pull request Sep 24, 2024
Open
@SanteriMertakorpi SanteriMertakorpi mentioned this pull request Sep 24, 2024
Merged
This was referenced Sep 25, 2024
Closed
Closed
Closed
@ananichoumchoum ananichoumchoum mentioned this pull request Sep 27, 2024
Open
@arenault-pass arenault-pass mentioned this pull request Sep 28, 2024
Closed
@yingbull yingbull mentioned this pull request Sep 28, 2024
Closed
@manh20012000 manh20012000 mentioned this pull request Sep 29, 2024
Open
@Alaa-1074002 Alaa-1074002 mentioned this pull request Sep 29, 2024
Open
@manh20012000 manh20012000 mentioned this pull request Oct 1, 2024
Open
This was referenced Oct 1, 2024
Closed
Closed
@phucle1010 phucle1010 mentioned this pull request Oct 2, 2024
Open
This was referenced Oct 3, 2024
Closed
Closed
This was referenced Oct 4, 2024
Closed
Closed
This was referenced Oct 5, 2024
Closed
Closed
@phucle1010 phucle1010 mentioned this pull request Oct 25, 2024
Open
@0xk4b1r 0xk4b1r mentioned this pull request Oct 28, 2024
Closed
@yingbull yingbull mentioned this pull request Oct 28, 2024
Closed
@phucle1010 phucle1010 mentioned this pull request Nov 1, 2024
Open
@Abyss0108 Abyss0108 mentioned this pull request Nov 3, 2024
Open
@0xk4b1r 0xk4b1r mentioned this pull request Nov 4, 2024
Closed
@PoojaPanchal12 PoojaPanchal12 mentioned this pull request Nov 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomekzaw tomekzaw tomekzaw approved these changes

@bartlomiejbloniarz bartlomiejbloniarz Awaiting requested review from bartlomiejbloniarz

@piaskowyk piaskowyk Awaiting requested review from piaskowyk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tjzel @tomekzaw