[LA Web] Add check for HTMLElement when looking for descendant with animation.
#5749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomekzaw
approved these changes
Mar 1, 2024
m-bert
added a commit
that referenced
this pull request
Mar 1, 2024
… animation. (#5749) ## Summary This issue was found in [Expensify](Expensify/App#37463). `node.children` was undefined, because `node` wasn't `HTMLElement` - it was `plaintext`. This PR introduces new check - if `node` is not `HTMLElement`, we won't perform any action. ## Test plan Tested on Expensify App
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This issue was found in Expensify.
node.childrenwas undefined, becausenodewasn'tHTMLElement- it wasplaintext. This PR introduces new check - ifnodeis notHTMLElement, we won't perform any action.Test plan
Tested on Expensify App