Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Reanimated Babel Plugin dependencies to dependencies #5716

Merged
merged 5 commits into from
Feb 22, 2024

Conversation

tjzel
Copy link
Collaborator

@tjzel tjzel commented Feb 22, 2024

Summary

After thinking about this, there's no reason for us to keep up the weird situation, with actually used Babel plugins in peer dependencies.

Reasons for that are:

  • those plugins are supposed to perform a given transformation, regardless of their version and whether they are proposals or not.
  • React Native is currently in progress of changing those proposal plugins to accepted ones, it would give it unnecessary maintenance to check which are available.

Test plan

I checked that our Example app works properly, there are no differences in Jest tests and also Reanimated works with Expensify's app.

@tjzel tjzel requested review from tomekzaw and piaskowyk February 22, 2024 17:05
package.json Outdated Show resolved Hide resolved
Copy link
Member

@piaskowyk piaskowyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for me 🫡

Copy link
Member

@tomekzaw tomekzaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let it be

@tjzel tjzel added this pull request to the merge queue Feb 22, 2024
Merged via the queue into main with commit fc21d37 Feb 22, 2024
13 checks passed
@tjzel tjzel deleted the @tjzel/clean-babel-dependencies branch February 22, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants