-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix warning about overwriting style with layout animation #5644
Conversation
Co-authored-by: Tomek Zawadzki <tomasz.zawadzki@swmansion.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this warning!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good, names of some variables could be better but it's very minor. Left a suggestion if you are interested in it, but your solution is good as well.
TS types are not the best, but since this file hasn't undergone proper typing it's okay.
Summary
In this PR #4969 I didn't include neither animatedStyles nor styles nested in arrays.
That's why the problem wasn't reported in this example: #5395
closes #5395
Test plan
Code