Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use install_modules_dependencies #5334

Merged
merged 15 commits into from
Nov 21, 2023
Merged

Use install_modules_dependencies #5334

merged 15 commits into from
Nov 21, 2023

Conversation

piaskowyk
Copy link
Member

@piaskowyk piaskowyk commented Oct 31, 2023 •
edited
Loading

Summary

Based on the changes in our libraries mentioned in this PR (software-mansion/react-native-gesture-handler#2635), we need to make adjustments to our .podspec file. We should utilize the install_modules_dependencies feature available in React Native since version 0.72.

Backward compatibility:
image

Test plan

Check CI

@piaskowyk piaskowyk marked this pull request as ready for review October 31, 2023 15:55
tomekzaw
tomekzaw reviewed Nov 2, 2023
View reviewed changes
RNReanimated.podspec Outdated Show resolved Hide resolved
RNReanimated.podspec Outdated Show resolved Hide resolved
RNReanimated.podspec Show resolved Hide resolved
piaskowyk and others added 2 commits November 10, 2023 10:30
@piaskowyk @tomekzaw
Update RNReanimated.podspec
e9535a4 
Co-authored-by: Tomek Zawadzki <tomasz.zawadzki@swmansion.com>
@piaskowyk @tomekzaw
Update RNReanimated.podspec
efb97af 
Co-authored-by: Tomek Zawadzki <tomasz.zawadzki@swmansion.com>
@piaskowyk piaskowyk requested a review from tomekzaw November 10, 2023 09:30
tomekzaw
tomekzaw reviewed Nov 13, 2023
View reviewed changes
RNReanimated.podspec Outdated Show resolved Hide resolved
tomekzaw
tomekzaw reviewed Nov 14, 2023
View reviewed changes
RNReanimated.podspec Outdated Show resolved Hide resolved
RNReanimated.podspec Outdated Show resolved Hide resolved
@piaskowyk piaskowyk requested a review from tomekzaw November 15, 2023 14:18
tomekzaw
tomekzaw reviewed Nov 15, 2023
View reviewed changes
RNReanimated.podspec Outdated Show resolved Hide resolved
RNReanimated.podspec Outdated Show resolved Hide resolved
@piaskowyk piaskowyk requested a review from tomekzaw November 16, 2023 09:55
tomekzaw
tomekzaw approved these changes Nov 20, 2023
View reviewed changes
RNReanimated.podspec Outdated Show resolved Hide resolved
@piaskowyk piaskowyk enabled auto-merge November 21, 2023 10:30
@piaskowyk piaskowyk added this pull request to the merge queue Nov 21, 2023
Merged via the queue into main with commit ab30d0d Nov 21, 2023
@piaskowyk piaskowyk deleted the @piaskowyk/install_modules_dependencies branch November 21, 2023 10:31
@piaskowyk piaskowyk mentioned this pull request Nov 21, 2023
Merged
github-merge-queue bot pushed a commit that referenced this pull request Nov 21, 2023
@piaskowyk @tomekzaw
Fix undefined config in podspec (#5390)
96810af 
## Summary

This PR fixes error:
```bash
[!] Invalid `Podfile` file: 
[!] Invalid `RNReanimated.podspec` file: undefined local variable or method `config' for Pod:Module
Did you mean?  concerning.

 #  from /Users/runner/work/react-native-reanimated/react-native-reanimated/Example/node_modules/react-native-reanimated/RNReanimated.podspec:90
 #  -------------------------------------------
 #    gcc_debug_definitions =  "$(inherited)"
 >    if config[:react_native_minor_version] >= 73 || !is_release
 #      gcc_debug_definitions << " HERMES_ENABLE_DEBUGGER=1"
 #  -------------------------------------------
.

 #  from /Users/runner/work/react-native-reanimated/react-native-reanimated/Example/ios/Podfile:31
 #  -------------------------------------------
 #  target 'ReanimatedExample' do
 >    config = use_native_modules!
 #  
 #  -------------------------------------------
 ```

Related to PRs: #5383 and #5334

It is because we renamed `config` to global variable `$config`

## Test plan

Build Example app

---------

Co-authored-by: Tomek Zawadzki <tomasz.zawadzki@swmansion.com>
Latropos pushed a commit that referenced this pull request Nov 24, 2023
@piaskowyk @tomekzaw
Use install_modules_dependencies (#5334)
558cce7 
## Summary

Based on the changes in our libraries mentioned in this PR
(software-mansion/react-native-gesture-handler#2635),
we need to make adjustments to our `.podspec` file. We should utilize
the `install_modules_dependencies` feature available in React Native
since version 0.72.

Backward compatibility:
<img width="126" alt="image"
src="https://github.com/software-mansion/react-native-reanimated/assets/36106620/ce5c1c67-8251-47d6-8d4b-98c959a4dfb8">

## Test plan

Check CI

---------

Co-authored-by: Tomek Zawadzki <tomasz.zawadzki@swmansion.com>
Latropos pushed a commit that referenced this pull request Nov 24, 2023
@piaskowyk @tomekzaw
Fix undefined config in podspec (#5390)
43c6ecf 
## Summary

This PR fixes error:
```bash
[!] Invalid `Podfile` file: 
[!] Invalid `RNReanimated.podspec` file: undefined local variable or method `config' for Pod:Module
Did you mean?  concerning.

 #  from /Users/runner/work/react-native-reanimated/react-native-reanimated/Example/node_modules/react-native-reanimated/RNReanimated.podspec:90
 #  -------------------------------------------
 #    gcc_debug_definitions =  "$(inherited)"
 >    if config[:react_native_minor_version] >= 73 || !is_release
 #      gcc_debug_definitions << " HERMES_ENABLE_DEBUGGER=1"
 #  -------------------------------------------
.

 #  from /Users/runner/work/react-native-reanimated/react-native-reanimated/Example/ios/Podfile:31
 #  -------------------------------------------
 #  target 'ReanimatedExample' do
 >    config = use_native_modules!
 #  
 #  -------------------------------------------
 ```

Related to PRs: #5383 and #5334

It is because we renamed `config` to global variable `$config`

## Test plan

Build Example app

---------

Co-authored-by: Tomek Zawadzki <tomasz.zawadzki@swmansion.com>
@genesiscz
Copy link

genesiscz commented Nov 30, 2023 •
edited
Loading

This broke our app - Your podspec is overriding our $config variable from our Podfile which caused post-install to fail. I am not sure if it's something you care about, but letting you know so you are aware of that :-)

@tomekzaw
Copy link
Member

@genesiscz Thanks for letting us know, we'll discuss how we can improve it. I hope you're the only one who's affected :)

Latropos pushed a commit that referenced this pull request Dec 12, 2023
@piaskowyk @tomekzaw
Use install_modules_dependencies (#5334)
a2f428b 
## Summary

Based on the changes in our libraries mentioned in this PR
(software-mansion/react-native-gesture-handler#2635),
we need to make adjustments to our `.podspec` file. We should utilize
the `install_modules_dependencies` feature available in React Native
since version 0.72.

Backward compatibility:
<img width="126" alt="image"
src="https://github.com/software-mansion/react-native-reanimated/assets/36106620/ce5c1c67-8251-47d6-8d4b-98c959a4dfb8">

## Test plan

Check CI

---------

Co-authored-by: Tomek Zawadzki <tomasz.zawadzki@swmansion.com>
Latropos pushed a commit that referenced this pull request Dec 12, 2023
@piaskowyk @tomekzaw
Fix undefined config in podspec (#5390)
462c4ad 
## Summary

This PR fixes error:
```bash
[!] Invalid `Podfile` file: 
[!] Invalid `RNReanimated.podspec` file: undefined local variable or method `config' for Pod:Module
Did you mean?  concerning.

 #  from /Users/runner/work/react-native-reanimated/react-native-reanimated/Example/node_modules/react-native-reanimated/RNReanimated.podspec:90
 #  -------------------------------------------
 #    gcc_debug_definitions =  "$(inherited)"
 >    if config[:react_native_minor_version] >= 73 || !is_release
 #      gcc_debug_definitions << " HERMES_ENABLE_DEBUGGER=1"
 #  -------------------------------------------
.

 #  from /Users/runner/work/react-native-reanimated/react-native-reanimated/Example/ios/Podfile:31
 #  -------------------------------------------
 #  target 'ReanimatedExample' do
 >    config = use_native_modules!
 #  
 #  -------------------------------------------
 ```

Related to PRs: #5383 and #5334

It is because we renamed `config` to global variable `$config`

## Test plan

Build Example app

---------

Co-authored-by: Tomek Zawadzki <tomasz.zawadzki@swmansion.com>
Latropos pushed a commit that referenced this pull request Dec 18, 2023
@piaskowyk @tomekzaw
Use install_modules_dependencies (#5334)
bbb9b74 
Based on the changes in our libraries mentioned in this PR
(software-mansion/react-native-gesture-handler#2635),
we need to make adjustments to our `.podspec` file. We should utilize
the `install_modules_dependencies` feature available in React Native
since version 0.72.

Backward compatibility:
<img width="126" alt="image"
src="https://github.com/software-mansion/react-native-reanimated/assets/36106620/ce5c1c67-8251-47d6-8d4b-98c959a4dfb8">

Check CI

---------

Co-authored-by: Tomek Zawadzki <tomasz.zawadzki@swmansion.com>
Latropos pushed a commit that referenced this pull request Dec 19, 2023
@piaskowyk @tomekzaw
Fix undefined config in podspec (#5390)
7acf6b6 
This PR fixes error:
```bash
[!] Invalid `Podfile` file:
[!] Invalid `RNReanimated.podspec` file: undefined local variable or method `config' for Pod:Module
Did you mean?  concerning.

 #  from /Users/runner/work/react-native-reanimated/react-native-reanimated/Example/node_modules/react-native-reanimated/RNReanimated.podspec:90
 #  -------------------------------------------
 #    gcc_debug_definitions =  "$(inherited)"
 >    if config[:react_native_minor_version] >= 73 || !is_release
 #      gcc_debug_definitions << " HERMES_ENABLE_DEBUGGER=1"
 #  -------------------------------------------
.

 #  from /Users/runner/work/react-native-reanimated/react-native-reanimated/Example/ios/Podfile:31
 #  -------------------------------------------
 #  target 'ReanimatedExample' do
 >    config = use_native_modules!
 #
 #  -------------------------------------------
 ```

Related to PRs: #5383 and #5334

It is because we renamed `config` to global variable `$config`

Build Example app

---------

Co-authored-by: Tomek Zawadzki <tomasz.zawadzki@swmansion.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomekzaw tomekzaw tomekzaw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@piaskowyk @genesiscz @tomekzaw